Update auth.ts to support "@azure/msal-browser": "^3.1.0" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See here for more info: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/errors.md#native_broker_called_before_initialize I tried to add the line after // start msal and before await msal.andleRedirectPromise() but that didn't work with me, so I added it after export const msal = new ... and that did work fine. Please review as I am not 100% sure if this is correct. I'm also not using TS.
Update auth.ts to support "@azure/msal-browser": "^3.1.0"
A folder containing a No TypeScript Version with a Dashboard instead of User view. Intended for a missing Express.js backend but it has local sample data. Co-Authored-By: Dave Stewart <[email protected]>
|
Hey! Thanks for the PR, will find time to review this week 🙏 |
Cleanup structure.
No type script version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
See here for more info:
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/errors.md#native_broker_called_before_initialize
I tried to add the line after
// start msal
and before
await msal.andleRedirectPromise()
but that didn't work with me, so I added it after
export const msal = new ...
and that did work fine.
Please review as I am not 100% sure if this is correct.
I'm also not using TS.