Skip to content
This repository has been archived by the owner on Nov 7, 2018. It is now read-only.

Improvements and docs for bullet charts #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Commits on Aug 31, 2014

  1. Bugfix: Render axis below horizontal plots.

    To reproduce: go to the vertical example, and change the orientation from
    "bottom" to "left". Observe the axis tick marks above the plot, reaching down
    into it.
    mgold committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    5426daa View commit details
    Browse the repository at this point in the history
  2. Render measurements after (above) markers.

    It's how Stephen Few wants it, from the design spec:
    Whenever the featured measure intersects a comparative measure, the comparative
    measure should usually appear behind the featured measure.
    mgold committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    9a09392 View commit details
    Browse the repository at this point in the history
  3. Inline default accessors to anonymous functions.

    Also, no need to specify a transform that does nothing.
    
    Mostly a style thing.
    mgold committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    8e7312f View commit details
    Browse the repository at this point in the history
  4. Add more classes to marker, range

    If I have multiple markers, I want the second to be less prominent.
    If I have charts with a varying number of ranges, I also need to know the total
    number of ranges.
    mgold committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    f374462 View commit details
    Browse the repository at this point in the history
  5. Don't always sort; allow explicit arrays.

    Rather than call ranges, markers, and measures, see if they're a function first.
    Sorting the markers is unhelpful: they won't occlude each other and it's helpful
    to be able to style the first marker more prominently.
    Sorting the measures is unhelpful for the same reason, we want to always know s0
    is the actual value and s1 is the forecast. However, for rendering, we sort them
    to prevent occlusion.
    mgold committed Aug 31, 2014
    Configuration menu
    Copy the full SHA
    7ef61b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2014

  1. Add documentation to README.

    Note that this documention reflects the changes I have made.
    mgold committed Oct 14, 2014
    Configuration menu
    Copy the full SHA
    a4aae50 View commit details
    Browse the repository at this point in the history