This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Improvements and docs for bullet charts #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce: go to the vertical example, and change the orientation from "bottom" to "left". Observe the axis tick marks above the plot, reaching down into it.
It's how Stephen Few wants it, from the design spec: Whenever the featured measure intersects a comparative measure, the comparative measure should usually appear behind the featured measure.
Also, no need to specify a transform that does nothing. Mostly a style thing.
If I have multiple markers, I want the second to be less prominent. If I have charts with a varying number of ranges, I also need to know the total number of ranges.
Rather than call ranges, markers, and measures, see if they're a function first. Sorting the markers is unhelpful: they won't occlude each other and it's helpful to be able to style the first marker more prominently. Sorting the measures is unhelpful for the same reason, we want to always know s0 is the actual value and s1 is the forecast. However, for rendering, we sort them to prevent occlusion.
|
Paging @jasondavies? |
Note that this documention reflects the changes I have made.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes, improvements, and documentation for bullet charts. Changes are broken out into multiple commits with detailed summaries.
You can see the changes at work in this bl.ocks; be sure to open in a new window.
Question: what would it take to move bullet charts into d3.format and out of the plugin repo?