Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display of workflow toolbar on narrow viewports #967

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Improve display of workflow toolbar on narrow viewports #967

merged 3 commits into from
Mar 30, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Mar 17, 2022 •
edited
Loading

These changes partially address #955

Medium viewport

Before

vld710_8000_user_rdutta_cylc__redirects=1 (1)

After

vld710_8000_user_rdutta_cylc__redirects=1

iPhone SE sized viewport

Before After
vld710_8000_user_rdutta_cylc__redirects=1(iPhone SE) vld710_8000_user_rdutta_cylc__redirects=1(iPhone SE) (1)

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (can't?).
  • No change log entry required (minor change).
  • No documentation update required.

@MetRonnie MetRonnie added the bug Something isn't working label Mar 17, 2022
@MetRonnie MetRonnie added this to the 1.1.0 milestone Mar 17, 2022
@MetRonnie MetRonnie self-assigned this Mar 17, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.1.0, 1.2.0 Mar 21, 2022
oliver-sanders
oliver-sanders approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, the workflow status message can get cut off entirely at some view widths but that's an accessible compromise.

hjoliver
hjoliver approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hjoliver hjoliver merged commit 81f9be9 into cylc:master Mar 30, 2022
@MetRonnie MetRonnie deleted the toolbar branch March 31, 2022 08:11
@MetRonnie MetRonnie mentioned this pull request Apr 5, 2022
Open
@MetRonnie MetRonnie linked an issue Apr 5, 2022 that may be closed by this pull request
workflow toolbar: improve for narrower viewports #955
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

@AaronDCole AaronDCole Awaiting requested review from AaronDCole

Assignees

@MetRonnie MetRonnie

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

workflow toolbar: improve for narrower viewports
3 participants
@MetRonnie @hjoliver @oliver-sanders