-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow toolbar: improve for narrower viewports #955
Comments
Is there a reason not to allow the title to wrap onto another line (so the toolbar occupies more height)? |
Truncation would look a lot nicer. We could supply the full name in a tooltip? |
Wrapping onto multiple lines would be ugly and require vertical expansion of the toolbar which would cut into the workflow workspace on smaller screens. The full ID is be available via the mutation menu. (note we should try to avoid on-hover tooltips as they are not mobile friendly, on-tap/click are ok but are typically used with a button style icon to make it clear they are interactive). |
The original idea for mobile was to break the toolbar over multiple lines: #87 (note the mobile view here does not support lumino tabs, you can only open one view at a time) |
If we want to make the ellipsis happen in the middle of the workflow name, rather than the end, this is a useful trick: https://css-tricks.com/using-flexbox-and-text-ellipsis-together/ |
This has mostly been fixed by #967, though there are still some enhancements that could be made as discussed in the thread. Changing the title and bumping to a later milestone |
Long workflow IDs should be truncated to ensure the information on the right of the toolbar remains visible.
Unfortunately with really long workflow IDs this is not always the case:
Sometimes the status string gets broken onto multiple lines. Sometimes the control icons, status string & add-view button are all pushed off the toolbar completely.
Related to this we could look at reducing directory names e.g. turn
foo/bar/baz/pub
intof/b/b/pub
when there is not enough space for the full name.Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read
CONTRIBUTING.md
before starting any work though).The text was updated successfully, but these errors were encountered: