Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow toolbar: improve for narrower viewports #955

Open
oliver-sanders opened this issue Mar 3, 2022 · 7 comments · Fixed by #967
Open

workflow toolbar: improve for narrower viewports #955

oliver-sanders opened this issue Mar 3, 2022 · 7 comments · Fixed by #967
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Mar 3, 2022

Update: this has been fixed, see discussion below for more possible improvements

Long workflow IDs should be truncated to ensure the information on the right of the toolbar remains visible.

Unfortunately with really long workflow IDs this is not always the case:

Screenshot 2022-03-03 at 09 29 04

Screenshot 2022-03-03 at 09 29 09

Sometimes the status string gets broken onto multiple lines. Sometimes the control icons, status string & add-view button are all pushed off the toolbar completely.


Related to this we could look at reducing directory names e.g. turn foo/bar/baz/pub into f/b/b/pub when there is not enough space for the full name.

Note: The full ID of the workflow can be obtained by clicking on the mutation button.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@oliver-sanders oliver-sanders added the bug Something isn't working label Mar 3, 2022
@oliver-sanders oliver-sanders added this to the 1.1.0 milestone Mar 3, 2022
@MetRonnie MetRonnie self-assigned this Mar 4, 2022
@MetRonnie
Copy link
Member

Is there a reason not to allow the title to wrap onto another line (so the toolbar occupies more height)?

@hjoliver
Copy link
Member

hjoliver commented Mar 7, 2022

Truncation would look a lot nicer. We could supply the full name in a tooltip?

@oliver-sanders
Copy link
Member Author

Wrapping onto multiple lines would be ugly and require vertical expansion of the toolbar which would cut into the workflow workspace on smaller screens. The full ID is be available via the mutation menu.

(note we should try to avoid on-hover tooltips as they are not mobile friendly, on-tap/click are ok but are typically used with a button style icon to make it clear they are interactive).

@MetRonnie
Copy link
Member

A problem with the current toolbar height is it really doesn't show much of the name at all on mobile (and this is after I've reduced the font size of the name):

This can be partially remedied by hiding the status on narrow viewports and making it available in the mutation menu

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Mar 7, 2022

The original idea for mobile was to break the toolbar over multiple lines: #87

Screenshot 2022-03-07 at 11 05 55

(note the mobile view here does not support lumino tabs, you can only open one view at a time)

Screenshot 2022-03-07 at 11 08 25

@MetRonnie
Copy link
Member

If we want to make the ellipsis happen in the middle of the workflow name, rather than the end, this is a useful trick: https://css-tricks.com/using-flexbox-and-text-ellipsis-together/

@MetRonnie
Copy link
Member

This has mostly been fixed by #967, though there are still some enhancements that could be made as discussed in the thread. Changing the title and bumping to a later milestone

@MetRonnie MetRonnie changed the title workflow toolbar: fix overflowing workflow IDs workflow toolbar: improve for narrower viewports Apr 5, 2022
@MetRonnie MetRonnie modified the milestones: 1.2.0, 2.0.0 Apr 5, 2022
@MetRonnie MetRonnie linked a pull request Apr 5, 2022 that will close this issue
6 tasks
@MetRonnie MetRonnie removed the bug Something isn't working label Apr 6, 2022
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@MetRonnie MetRonnie removed their assignment Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants