-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralise task filtering into own component; list task states in logical order #1123
Conversation
2c76ec7
to
506e5b8
Compare
Due to the refactoring this will be a tricky one to reconcile with the graph view / data store work as filtering works in a different way when views are powered from the central data store. |
What's your suggestion - shelve this one? |
I have looked at #1108 and I don't see too much surface area for conflict, only a handful of lines |
I haven't got filtering working in all views on that branch yet. The main difference is that in order to drive the views off of the central data store we cannot change the data or set attributes on it directly. Instead we must store the filter state in the view locally. I'm going to try to get back to that branch this week to see if I can clear out the remaining issues and find out. |
Note that currently this new filter component does not house the logic of the filtering, that is left up to the parent components that use/embed the filter component |
Converting to draft, will be easier to deconflict this one after #1108 has gone in |
d359fee
to
457c8f5
Compare
457c8f5
to
810075b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,38 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps move into src/utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read code.
- Tried functionality.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.