-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix dt-mean #1164
table: fix dt-mean #1164
Conversation
a5ccf97
to
4920b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the delta symbol instead of "d"?
Could do but I'm not sure that was a positive change. Should probably rethink the timing headers some time. |
Oh, test failing after my suggestion was committed because it was expecting a ΔT of 0 to be converted to ''. I have had a look at a real workflow and it seems that runahead tasks that have not run in a previous cycle get a mean elapsed time of 0 when it should probably be nullish (running tasks that have not run in a previous cycle get a nullish value). In the mock data there are several tasks that have a mean elapsed time of 0 which should probably be >0 if the task has a T-finish, else nullish. Or, you could just undo my suggestion |
147f510
to
7575ad0
Compare
Going to revert the suggestion in order to keep this as robust as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion for clarifying comment
@oliver-sanders - this now conflicts with master after merger of #1123 |
I've just tried this out and it doesn't seem to be working at all for me. |
7575ad0
to
e4e5206
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it out and it's working for me. Just the changelog that is conflicting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read code.
Applies the fix from #1112 onto master and adds tests.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.