Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: fix dt-mean #1164

Merged
merged 2 commits into from
Jan 4, 2023
Merged

table: fix dt-mean #1164

merged 2 commits into from
Jan 4, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Dec 12, 2022

Applies the fix from #1112 onto master and adds tests.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@oliver-sanders oliver-sanders added the bug Something isn't working label Dec 12, 2022
@oliver-sanders oliver-sanders added this to the 1.4.0 milestone Dec 12, 2022
@oliver-sanders oliver-sanders self-assigned this Dec 12, 2022
@oliver-sanders oliver-sanders mentioned this pull request Dec 12, 2022
10 tasks
@oliver-sanders oliver-sanders requested review from MetRonnie and removed request for wxtim December 21, 2022 11:57
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the delta symbol instead of "d"?

src/components/cylc/table/Table.vue Outdated Show resolved Hide resolved
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Dec 21, 2022

What about the delta symbol instead of "d"?

Could do but I'm not sure that was a positive change. Should probably rethink the timing headers some time.

@MetRonnie
Copy link
Member

Oh, test failing after my suggestion was committed because it was expecting a ΔT of 0 to be converted to ''. I have had a look at a real workflow and it seems that runahead tasks that have not run in a previous cycle get a mean elapsed time of 0 when it should probably be nullish (running tasks that have not run in a previous cycle get a nullish value). In the mock data there are several tasks that have a mean elapsed time of 0 which should probably be >0 if the task has a T-finish, else nullish.

Or, you could just undo my suggestion

@oliver-sanders
Copy link
Member Author

Going to revert the suggestion in order to keep this as robust as possible.

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion for clarifying comment

src/components/cylc/table/Table.vue Show resolved Hide resolved
@wxtim
Copy link
Member

wxtim commented Jan 4, 2023

@oliver-sanders - this now conflicts with master after merger of #1123

@wxtim
Copy link
Member

wxtim commented Jan 4, 2023

I've just tried this out and it doesn't seem to be working at all for me.

@oliver-sanders
Copy link
Member Author

Rebased

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it out and it's working for me. Just the changelog that is conflicting

@wxtim
Copy link
Member

wxtim commented Jan 4, 2023

  • Checks that it works in practice.

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read code.

@wxtim wxtim merged commit 2d197c7 into cylc:master Jan 4, 2023
@oliver-sanders oliver-sanders deleted the dt-mean branch January 4, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants