Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small changes to coiled/aws examples #369

Merged
merged 4 commits into from
Feb 26, 2024
Merged

small changes to coiled/aws examples #369

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
646b726
Update README.md
rsignell Feb 1, 2024
a9b2905
Update coiled-add-asarray.py
rsignell Feb 1, 2024
5326c96
Update coiled-add-random.py
rsignell Feb 1, 2024
66d2b42
Add missing comma
tomwhite Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/coiled/aws/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
3. Install a Python environment with the coiled package in it by running the following from this directory:

```shell
conda create --name cubed-coiled-examples -y python=3.9
conda create -n cubed-coiled-examples python=3.9 -y
conda activate cubed-coiled-examples
pip install 'cubed[coiled]'
```
Expand Down
2 changes: 1 addition & 1 deletion examples/coiled/aws/coiled-add-asarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
c = xp.add(a, b)
res = c.compute(
executor=executor,
memory="1 GiB", # must be greater than allowed_mem
memory=["1 GiB", "8 GiB"] # memory range
Copy link
Member

@tomwhite tomwhite Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a missing comma here?

Also might be worth preserving the previous comment too:

# memory range, lower value must be at least allowed_mem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise we could submit a range now, that's nice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear - the memory argument is passed through to the Coiled function, it's not interpreted by Cubed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right

spot_policy="spot_with_fallback", # recommended
account=None, # use your default account (or change to use a specific account)
keepalive="30 seconds", # change this to keep clusters alive longer
Expand Down
2 changes: 1 addition & 1 deletion examples/coiled/aws/coiled-add-random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
store=None,
executor=executor,
callbacks=[progress, hist, timeline_viz],
memory="2 GiB", # must be at least allowed_mem
memory=["2 GiB", "8 GiB"], # memory range
spot_policy="spot_with_fallback", # recommended
account=None, # use your default account (or change to use a specific account)
keepalive="30 seconds", # change this to keep clusters alive longer
Expand Down
Loading