small changes to coiled/aws examples #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
reviewed
Feb 1, 2024
| @@ -21,7 +21,7 @@ | |||
| c = xp.add(a, b) | |||
| res = c.compute( | |||
| executor=executor, | |||
| memory="1 GiB", # must be greater than allowed_mem | |||
| memory=["1 GiB", "8 GiB"] # memory range | |||
There was a problem hiding this comment.
Looks like there's a missing comma here?
Also might be worth preserving the previous comment too:
# memory range, lower value must be at least allowed_mem
There was a problem hiding this comment.
I didn't realise we could submit a range now, that's nice
There was a problem hiding this comment.
To be clear - the memory argument is passed through to the Coiled function, it's not interpreted by Cubed.
|
Thanks for the contribution @rsignell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few minor changes that were necessary for me to run the examples on coiled. I needed to run with the latest version of coiled (I did
pip install coiled==1.3.12.dev12), for more info see coiled/feedback#271