Add new keys and getter / setter functions #7378
Conversation
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
| @@ -15,6 +15,7 @@ import ( | |||
|
|
|||
| "github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types" | |||
| host "github.com/cosmos/ibc-go/v9/modules/core/24-host" | |||
| hostv2 "github.com/cosmos/ibc-go/v9/modules/core/24-host/v2" | |||
There was a problem hiding this comment.
new keys have been added under a host/v2
| // PacketReceiptKey returns the store key of under which a packet | ||
| // receipt is stored | ||
| func PacketReceiptKey(sourceID string, sequence uint64) []byte { | ||
| return []byte(fmt.Sprintf("receipts/channels/%s/sequences/%d", sourceID, sequence)) |
There was a problem hiding this comment.
we can introduce utility functions if needed, but I didn't think it was necessary here
| } | ||
|
|
||
| // GetNextSequenceSend returns the next send sequence from the sequence path | ||
| func (k *Keeper) GetNextSequenceSend(ctx context.Context, sourceID string) (uint64, bool) { |
| @@ -61,3 +62,96 @@ func (k *Keeper) GetCounterparty(ctx context.Context, clientID string) (types.Co | |||
| k.cdc.MustUnmarshal(bz, &counterparty) | |||
| return counterparty, true | |||
| } | |||
|
|
|||
| // GetPacketReceipt returns the packet receipt from the packet receipt path based on the sourceID and sequence. | |||
| func (k *Keeper) GetPacketReceipt(ctx context.Context, sourceID string, sequence uint64) (string, bool) { | |||
There was a problem hiding this comment.
oh, weren't all sequences in keys now to be stored using big endian?
There was a problem hiding this comment.
fine if issue for later too (might already exist and I missed it)
There was a problem hiding this comment.
Sequences should be in big endian as specified by @DimitrisJim. Is there a way to specify that in the go code? Which is the default option in go?
There was a problem hiding this comment.
yea, we can specify it, https://github.com/cosmos/ibc-go/pull/7378/files#diff-9ed2f6c5ff81737b0b1ff368007a1d90faf54d6de2ea118f9698f23293cc3348R153 is an example currently in use!
There was a problem hiding this comment.
With new keys we should probably consider how we format the sequence in order to support effecient iteration, right?
I think this was an issue before, as formatting ended up in lexographical ordering rather than numerical(?)
E.g. format sequence using big endian bytes rather than decimal string
There was a problem hiding this comment.
yes! Was just chatting to @DimitrisJim about it, seems like we do indeed want to use BigEndian, pushing changes now.
There was a problem hiding this comment.
Should've refreshed my browser before publishing review... 😆
| // PacketReceiptKey returns the store key of under which a packet | ||
| // receipt is stored | ||
| func PacketReceiptKey(sourceID string, bigEndianSequence []byte) []byte { | ||
| return []byte(fmt.Sprintf("receipts/channels/%s/sequences/%s", sourceID, string(bigEndianSequence))) |
There was a problem hiding this comment.
%s implicitly calls string on arg no?
| // GetPacketCommitment returns the packet commitment hash under the commitment path. | ||
| func (k *Keeper) GetPacketCommitment(ctx context.Context, sourceID string, sequence uint64) (string, bool) { | ||
| store := k.storeService.OpenKVStore(ctx) | ||
| bigEndianBz := sdk.Uint64ToBigEndian(sequence) |
There was a problem hiding this comment.
don't want to be nitting too hard but might be nicer to do this inside host pkg. API looks friendlier with a uint64 sequence, and the formatting is a host responsibility imo 🤷🏻
|
chatton
deleted the
cian/issue#7366-add-store-functions-to-the-channelkeeper-v2-that-use-the-new-provable-paths
branch
Description
NOTE: explicitly not closing linked issue, as these fields are subject to change pending final spec.
With these we can continue with implementations of new handler functions.
ref: #7366
closes #7132
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.