Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store sequences using big endian encoding to retain numeric ordering #5752

Closed
2 of 3 tasks
DimitrisJim opened this issue Jan 26, 2024 · 1 comment
Closed
2 of 3 tasks

Store sequences using big endian encoding to retain numeric ordering #5752

DimitrisJim opened this issue Jan 26, 2024 · 1 comment
Labels
change: protocol breaking Issues that cannot be addressed because they break the current protocol version change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@DimitrisJim
Copy link
Contributor

Currently they are stored after being formatted in a string, resulting in lexicographic ordering when iterating through them. This is slightly counter-intuitive at first and can limit operations that operate over the full list of sequences by iterating through the stored values. (Pruning is a recent example).

Opening issue to keep track of idea.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) labels Jan 26, 2024
@crodriguezvega crodriguezvega added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jan 26, 2024
@colin-axner colin-axner added the change: protocol breaking Issues that cannot be addressed because they break the current protocol version label Feb 13, 2024
@DimitrisJim DimitrisJim mentioned this issue Aug 21, 2024
Closed
3 tasks
@DimitrisJim
Copy link
Contributor Author

I think this was also addressed as part of #7378? We solely have packet keys in v2 which were changed as part of #7132.

Going to close, old keys stay the same IIRC, feel free to re-open if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change: protocol breaking Issues that cannot be addressed because they break the current protocol version change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crodriguezvega @DimitrisJim @colin-axner