-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KB-1230: Update Kima testnet URLs #5815
Draft
Ben-Kima
wants to merge
23
commits into
cosmos:master
Choose a base branch
from
kima-finance:KB-1230/Update-Kima-testnet-URLs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
dacaf33
IBC channel register
dawn227 c0ddecb
WIP
Ben-Kima 4d0528f
Finalise config
Ben-Kima 299d2ee
Merge branch 'master' of github.com:cosmos/chain-registry into kima-t…
Ben-Kima 7085e26
move ibc config file to testnet directory
dawn227 92e9293
rename file
dawn227 e725d68
Registring Kima Netowrk
waelkima 3babcfa
Merge remote-tracking branch 'origin/kima-testnet'
waelkima 48aca5a
Merge branch 'master' of github.com:cosmos/chain-registry
Ben-Kima c379c0a
Merge branch 'master' of github.com:kima-finance/chain-registry
Ben-Kima 058692d
Fix conflicts
Ben-Kima eaf097d
Merge branch 'cosmos:master' into master
Ben-Kima c195aef
Merge remote-tracking branch 'upstream/master'
Ben-Kima 8cb01b8
Remove legacy things
Ben-Kima d8a9392
Initial commit
Ben-Kima b43c354
Add grpc endpoint
Ben-Kima d9b0447
Merge remote-tracking branch 'upstream/master'
gilkima 1863bc0
sync
gilkima 3058c10
update sentry address
gilkima 45e7782
Merge branch 'master' of github.com:cosmos/chain-registry
Ben-Kima 78db44e
Merge branch 'master' of github.com:kima-finance/chain-registry
Ben-Kima 7922978
Merge branch 'master' into KB-1230/Update-Kima-testnet-URLs
Ben-Kima a2d663b
Update data
Ben-Kima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"versions"
not longer belongs under"codebase"
, but instead goes to another file calledversions.json
.The
"versions"
property must be removed from both chain.json files to pass validation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jeremy, I have quite a few changes including this locally that we will push in the coming days and then look forward to your feedback thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeremyParish69 the changes should now be ready for your review with the checks all passing ✅
I'm curious as to whether you have any links or docs you can share that better describe the traces section? They would be greatly appreciated 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left just a couple more suggestions for corrects and then it should be good to go.
Unfortunately I don't have more documentation of
traces
at the moment. I think I'll need to write some.