KB-1230: Update Kima testnet URLs #5815
Conversation
kimanetwork/chain.json
Outdated
| "genesis": { | ||
| "genesis_url": "https://archive.kima.network/genesis.json" | ||
| } | ||
| }, | ||
| "versions": [ |
There was a problem hiding this comment.
"versions" not longer belongs under "codebase", but instead goes to another file called versions.json.
The "versions" property must be removed from both chain.json files to pass validation.
There was a problem hiding this comment.
Thanks Jeremy, I have quite a few changes including this locally that we will push in the coming days and then look forward to your feedback thanks.
There was a problem hiding this comment.
@JeremyParish69 the changes should now be ready for your review with the checks all passing ✅
I'm curious as to whether you have any links or docs you can share that better describe the traces section? They would be greatly appreciated 🙏
There was a problem hiding this comment.
I left just a couple more suggestions for corrects and then it should be good to go.
Unfortunately I don't have more documentation of traces at the moment. I think I'll need to write some.
| "genesis": { | ||
| "genesis_url": "https://archive.kima.network/genesis.json" | ||
| }, | ||
| "consensus": { |
There was a problem hiding this comment.
The consensus, language, sdk, and ibc, are better stored in the "versions" file (but here is fine to include, as well).
| @@ -43,6 +43,7 @@ | |||
| "svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/kimanetwork/images/kima.svg" | |||
| } | |||
| ], | |||
| "coingecko_id": "kima", | |||
There was a problem hiding this comment.
Please remove the coingecko ID. We don't add them to testnet assets
| "genesis_url": "http://data-testnet.kima.finance/genesis.json" | ||
| "genesis_url": "http://archive.sardis.kima.network/genesis.json" | ||
| }, | ||
| "consensus": { |
There was a problem hiding this comment.
Please copy or move these properties (consensus, lenguage, sdk, ibc) into the version object in the "versions.json" file.
No description provided.