Handle zero hops separately if all travel times in feed are rounded #145
Conversation
| // If travel times are rounded and travel time is zero, determine the maximum and minimum possible speed | ||
| // by adding/removing one minute of slack. | ||
| if (bothTravelTimesRounded && travelTimeSeconds == 0) | ||
| travelTimeSeconds += 60; |
There was a problem hiding this comment.
Please put brackets around conditional bodies unless there's no line break.
|
@landonreed I approved the PR in principle (though there's request for a bracket change), and realized afterward that two snapshot tests are failing. |
|
Thanks, @abyrd. Yes, I think I need to update the failing test/snapshot. I'll do that today so we can get this merged in. |
Conflicts: src/test/resources/snapshots/com/conveyal/gtfs/graphql/GTFSGraphQLTest/canFetchErrors.json
Codecov Report
@@ Coverage Diff @@
## dev #145 +/- ##
============================================
- Coverage 55.21% 55.15% -0.06%
- Complexity 734 736 +2
============================================
Files 143 143
Lines 7178 7198 +20
Branches 830 833 +3
============================================
+ Hits 3963 3970 +7
- Misses 2876 2885 +9
- Partials 339 343 +4
Continue to review full report at Codecov.
|
|
Note: future work on rounded travel times should reference #157. |
|
🎉 This PR is included in version 4.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR implements the changes suggested by @abyrd in #110 (comment).
cc @Tristramg