Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add per-route check for rounded stop_times #157

Open
landonreed opened this issue Nov 30, 2018 · 0 comments
Open

Enhancement: add per-route check for rounded stop_times #157

landonreed opened this issue Nov 30, 2018 · 0 comments

Comments

@landonreed
Copy link
Contributor

After discussion with @abyrd and @evansiroky of #145, we have concluded that the PR fixes the primary issue (abounding validation issues for zero hops), but that there could be feeds (e.g., a merged feed for an entire nation) that contain routes which treat rounded stop_times differently and we could still amass a large number of zero hop validation issues.

A future improvement might be to keep track of rounded stop_times on a per-route basis and only store a validation issue for rounded stop_times for individual routes. So the different scenarios for feeds could be:

  1. all stop_times rounded (feed-wide validation issue)
  2. some n routes with all stop_times rounded (n route-level issues, perhaps a handful of zero hops were flagged)
  3. no routes with all stop_times rounded (perhaps a handful of zero hops were flagged).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant