Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep 2024 #135

Merged
merged 4 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.html
14 changes: 7 additions & 7 deletions .github/workflows/check-full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@ jobs:
- { os: windows-latest, r: "oldrel-1" }

# Use older ubuntu to maximise backward compatibility
- { os: ubuntu-18.04, r: "devel", http-user-agent: "release" }
- { os: ubuntu-18.04, r: "release" }
- { os: ubuntu-18.04, r: "oldrel-1" }
- { os: ubuntu-18.04, r: "oldrel-2" }
- { os: ubuntu-18.04, r: "oldrel-3" }
- { os: ubuntu-18.04, r: "oldrel-4" }
- { os: ubuntu-latest, r: "devel", http-user-agent: "release" }
- { os: ubuntu-latest, r: "release" }
- { os: ubuntu-latest, r: "oldrel-1" }
- { os: ubuntu-latest, r: "oldrel-2" }
- { os: ubuntu-latest, r: "oldrel-3" }
- { os: ubuntu-latest, r: "oldrel-4" }

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-pandoc@v2

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-r@v2
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pkgdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-pandoc@v2-branch
- uses: r-lib/actions/setup-pandoc@v2

- uses: r-lib/actions/setup-r@v2
with:
Expand All @@ -35,7 +35,7 @@ jobs:

- name: Deploy to GitHub pages 🚀
if: github.event_name != 'pull_request'
uses: JamesIves/github-pages-deploy-action@v4.4.1
uses: JamesIves/github-pages-deploy-action@v4.6.0
with:
clean: false
branch: gh-pages
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-r@v2
with:
Expand Down
23 changes: 22 additions & 1 deletion .lintr
Original file line number Diff line number Diff line change
@@ -1 +1,22 @@
linters: with_defaults(object_name_linter=NULL,line_length_linter(100),trailing_whitespace_linter=NULL, open_curly_linter = NULL, closed_curly_linter = NULL)
linters: all_linters(
absolute_path_linter = NULL,
assignment_linter = NULL,
commented_code_linter = NULL,
cyclocomp_linter(25L),
if_not_else_linter(exceptions = character(0L)),
implicit_integer_linter = NULL,
library_call_linter = NULL,
line_length_linter(120L),
namespace_linter = NULL,
nonportable_path_linter = NULL,
object_name_linter = NULL,
object_length_linter(50L),
object_usage_linter = NULL,
todo_comment_linter = NULL,
string_boundary_linter = NULL,
strings_as_factors_linter = NULL,
undesirable_function_linter = NULL,
undesirable_operator_linter = NULL,
unnecessary_concatenation_linter(allow_single_expression = FALSE),
unused_import_linter = NULL
)
5 changes: 3 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,19 @@ Description: Enrich your 'ggplots' with group-wise comparisons.
License: GPL-3 | file LICENSE
URL: https://const-ae.github.io/ggsignif/,
https://github.com/const-ae/ggsignif
BugReports: https://github.com/const-ae/ggsignif/issues
VignetteBuilder:
knitr
Encoding: UTF-8
Language: en-US
Imports:
ggplot2 (>= 3.4.0)
ggplot2 (>= 3.5.0)
Suggests:
knitr,
rmarkdown,
testthat,
vdiffr (>= 1.0.5)
Roxygen: list(markdown = TRUE, roclets = c("rd", "namespace", "collate"))
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
Config/testthat/edition: 3
Config/testthat/parallel: true
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,10 @@ to group the data per geom (e.g., set the fill within
``` r
ggplot(diamonds, aes(x = cut, y = carat)) +
geom_boxplot(aes(fill = color)) +
geom_signif(comparisons = list(c("Fair", "Good"),
c("Very Good", "Ideal"))) +
geom_signif(comparisons = list(
c("Fair", "Good"),
c("Very Good", "Ideal")
)) +
facet_wrap(~color) +
ylim(NA, 6.3)
```
Expand Down
Binary file modified man/figures/README-dodge_comparison-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-faceted_simple-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions man/ggsignif-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

178 changes: 0 additions & 178 deletions tests/testthat/_snaps/snapshot_data.md

This file was deleted.

2 changes: 1 addition & 1 deletion tests/testthat/_snaps/vdiffr/basic-plot.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading