Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep 2024 #135

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Upkeep 2024 #135

merged 4 commits into from
Apr 23, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@@ -90,3 +90,72 @@ test_that("plots are rendered correctly", {
scale_fill_manual(values = c("grey80", "grey20"))
)
})

test_that("method which return text works - snapshot", {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, we were testing internal implementation details of ggplot2 by snapshotting the plot data.
We are instead interested in how the plot looks, and so a visual snapshot test is better.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Owner

@const-ae const-ae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the maintenance update. Looks all great :)

@@ -90,3 +90,72 @@ test_that("plots are rendered correctly", {
scale_fill_manual(values = c("grey80", "grey20"))
)
})

test_that("method which return text works - snapshot", {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@const-ae
Copy link
Owner

Do you think the changes warrant a CRAN update or is it fine to just leave it like this as it is mostly about tests anyways?

@IndrajeetPatil
Copy link
Collaborator Author

Do you think the changes warrant a CRAN update or is it fine to just leave it like this as it is mostly about tests anyways?

No, I don't think so: there hasn't been any user-visible change from any of these changes.

@IndrajeetPatil IndrajeetPatil merged commit 6e9c62e into main Apr 23, 2024
13 checks passed
@IndrajeetPatil IndrajeetPatil deleted the upkeep-24 branch April 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants