Upkeep 2024 #135
Merged
Upkeep 2024 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndrajeetPatil
commented
Apr 22, 2024
| @@ -90,3 +90,72 @@ test_that("plots are rendered correctly", { | |||
| scale_fill_manual(values = c("grey80", "grey20")) | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("method which return text works - snapshot", { | |||
There was a problem hiding this comment.
Before, we were testing internal implementation details of ggplot2 by snapshotting the plot data.
We are instead interested in how the plot looks, and so a visual snapshot test is better.
const-ae
reviewed
Apr 23, 2024
| @@ -90,3 +90,72 @@ test_that("plots are rendered correctly", { | |||
| scale_fill_manual(values = c("grey80", "grey20")) | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("method which return text works - snapshot", { | |||
|
Do you think the changes warrant a CRAN update or is it fine to just leave it like this as it is mostly about tests anyways? |
No, I don't think so: there hasn't been any user-visible change from any of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.