Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Pin pydantic version #836

Closed
wants to merge 4 commits into from
Closed

MAINT - Pin pydantic version #836

wants to merge 4 commits into from

Conversation

trallard
Copy link
Collaborator

We started seeing CI failures with pydantic 1.10.15 so needed to add a pin to avoid such a version

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 0649228
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6671740b64f27e0008b79fd6

@trallard trallard mentioned this pull request Jun 18, 2024
3 tasks
@trallard trallard requested a review from peytondmurray June 18, 2024 11:43
@trallard trallard added type: bug 🐛 Something isn't working area: dependencies 📦 Issues related to conda-store dependencies area: CI 👷🏽‍♀️ labels Jun 18, 2024
@trallard
Copy link
Collaborator Author

@peytondmurray this is working now
Note that there has not been a release for pydantic on conda-forge yet so the alternative there is to pin the Python version (less than ideal but a quick fix for now)

Ready for review

- fastapi
- filelock
- itsdangerous
- jinja2
- minio
# @trallard there is no updated version in conda-forge
# need to come back and pin =1.10.16,<2.0a0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# need to come back and pin =1.10.16,<2.0a0
# need to come back and pin >=1.10.16,<2.0a0

@jaimergp
Copy link
Member

conda-forge/conda-forge-repodata-patches-feedstock#779 should make this unnecessary. Also conda-forge/pydantic-feedstock#125 is in, so 1.10.6 should be available soon.

@trallard trallard closed this Jun 18, 2024
@trallard trallard deleted the trallard/fix-recipe branch August 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI 👷🏽‍♀️ area: dependencies 📦 Issues related to conda-store dependencies needs: review 👀 type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants