Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Fix triggers #837

Merged
merged 3 commits into from
Jun 19, 2024
Merged

BUG - Fix triggers #837

merged 3 commits into from
Jun 19, 2024

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Jun 18, 2024

Description

It seems the triggers updates in #832 are not currently working using the ! ignore pattern in paths.
This PR changes such triggers to an explicit include paths pattern.

🚨 The build conda package workflow will fail until we merge #836

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

How to test

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 0ba2780
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/667171902d21b40008f4ebe2

@trallard trallard requested a review from peytondmurray June 18, 2024 11:33
@trallard
Copy link
Collaborator Author

@peytondmurray seems the triggers are working now as they should (the conda recipe check is still failing but should be fixed in #836)

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🚢

@peytondmurray peytondmurray merged commit 3385723 into main Jun 19, 2024
26 of 27 checks passed
@peytondmurray peytondmurray deleted the trallard/fix-triggers branch June 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants