Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 py312 #44

Merged
merged 52 commits into from
Oct 7, 2024
Merged

Qt6 py312 #44

merged 52 commits into from
Oct 7, 2024

Conversation

looooo
Copy link
Contributor

@looooo looooo commented Nov 26, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits November 26, 2023 21:46
@looooo
Copy link
Contributor Author

looooo commented Nov 29, 2023

Thanks @hmaarrfk. Before I can merge this I wait for another update of coin because the previous patch release added some abi-incompatibilities for windows coin3d/coin#513
Also there is one failing build here: coin3d/pivy#108 (comment)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [39]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@looooo looooo mentioned this pull request Dec 4, 2023
5 tasks
@adrianinsaval
Copy link

anything holding this back?

@h-vetinari
Copy link
Member

Windows builds are passing now; the only failure is on aarch with CMake not finding numpy; you might find some help/inspiration in conda-forge/conda-forge.github.io#2260 and references therein.

@looooo
Copy link
Contributor Author

looooo commented Oct 3, 2024

Is pyside2 for python3.12 now available. I expected these builds to fail.

packages are skipped, but ci-files are created with conda-smithy rerender.

@looooo
Copy link
Contributor Author

looooo commented Oct 4, 2024

Windows builds are passing now; the only failure is on aarch with CMake not finding numpy; you might find some help/inspiration in conda-forge/conda-forge.github.io#2260 and references therein.

not sure I understand correctly, but numpy is not a dependency of pivy.

@looooo
Copy link
Contributor Author

looooo commented Oct 6, 2024

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

h-vetinari commented Oct 6, 2024

Don't manually remove CI files. They don't really hurt as long as the skips are done correctly, and the risk of breaking something by manual intervention is not worth it

If you want to ensure these jobs do not get created by conda-smithy, you need to ensure that all outputs (including the recipe-global build: section) have the corresponding skip present

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 6, 2024

ps you should rerendering when changing the yum_requirements.txt file

@looooo
Copy link
Contributor Author

looooo commented Oct 6, 2024

@conda-forge-admin, please rerender

@looooo
Copy link
Contributor Author

looooo commented Oct 6, 2024

Why x86_64 dependencies (yum) are pulled for cross compiled linuxaarch64 ?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11205186406.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 6, 2024

Why x86_64 dependencies (yum) are pulled for cross compiled linuxaarch64 ?

Because you are cross compiling.

build_platform:
  linux_aarch64: linux_64

@looooo looooo merged commit dd6f8aa into conda-forge:main Oct 7, 2024
42 checks passed
@h-vetinari
Copy link
Member

Nice, well done. Next stop freecad. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants