-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6, pcl 1.14.1, occt 7.8.1, vtk 9.3.1, boost 1.86 #122
base: main
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2024.06.07.18.45.09
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
…nda-forge-pinning 2024.06.08.16.24.57
…nda-forge-pinning 2024.06.08.16.24.57
…nda-forge-pinning 2024.06.10.16.24.12
I would not recommend shipping 0.21.2 with qt6, hang on a bit I will be finishing back porting some things to the 0.21 branch and making a final release around the weekend. We can make a qt6 version then |
This is for testing only. My goal was to upload 0.22pre packages to freecad/label/qt6. But there is still something missing:
|
…nda-forge-pinning 2024.06.30.11.04.33
@conda-forge/core anyone able to tell what package is missing for the vtk9.3.0 migration:
|
it might be that |
Definitely, that sounds like a great solution! I wasn't aware of your old PR, but it sounds like we should try reactivating it? |
can you explain what this does. I think for qt5 we need to specify an older vtk version as vtk was updated to be build against qt6 with more reccent versions.. |
The idea would be that we could do something like: {% if qt|int >=6 %}
- qt6-main
- pyside6
- noqt5 # <-- !
{% else %}
- qt-main
- pyside2
- noqt6 # <-- !
{% endif %} and so avoid having two different qt versions in the host environment, which confuses CMake currently. |
I reopened it. Review appreciated. |
I think about removing qt5 from the build matrix. qt5 needs several older (not up to date) dependencies. We can support qt5 via another branch. |
freecad on qt6 has had very little testing and maintainers preferred to stay primarily on qt5 for this release so IMO a qt6 version should be a secondary build not the main one. I'll try again bringing qt5 and other dependencies up to date this week |
I'm less sure that the If pyvi is such a tight dependency at build time in terms of qt5/qt6 i think that it warrants a build string that would specify qt5/qt6 to help lock it in step with freecad. |
I'm not really sure what this means. I keep both qt5 and qt6 updated. they should both have the same dependency matrix. So maybe you have freecad dependencies that need to be built for both. That can in fact be troubling... |
pivy is not needed for the build. It is only a runtime tependency.
recent versions of vtk are build only against qt6. Pyside2 is not working with python 3.12. And qt5/qt6 matrix complicates everything a lot. |
Is there a world we’re the next released version of pivy old be built only for qt6? that might simplify your constraints a lot. Ps. Apparently there exists a finite set of patches for pyside2 to get it to work on Python 3.12 and 3.13. See feedstock for details. |
…nda-forge-pinning 2024.10.17.15.21.02
…nda-forge-pinning 2024.10.18.09.40.47
…nda-forge-pinning 2024.10.25.18.47.03
recipe/bld.bat
Outdated
mkdir build | ||
cd build | ||
rem this is not needed anymore? | ||
rem rm -rf C:/hostedtoolcache/windows/Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is still needed:
-- Shiboken6Config: Using default python: .cp310-win_amd64
CMake Error at D:/bld/freecad_1730024460162/_h_env/Library/lib/cmake/Shiboken6/ShibokenHelpers.cmake:474 (message):
-- Found Python: C:/hostedtoolcache/windows/Python/3.12.7/x64/python3.exe (found suitable version "3.12.7", minimum required is "3") found components: Interpreter Development Development.Module Development.Embed
The detected Python minor version is not compatible with the Python minor
although I would put this on an if statement to detect if running in azure if possible
…nda-forge-pinning 2024.11.06.14.03.29
windows now fails with:
The shiboken configuration runs and later on for python312 with the mysterios unsolveable:
|
can we change this feedstock to rattler-build? |
If you need a specific python version, put it in
rattler-build recipes are allowed, so if you get it working, go for it. However, the python issue is going to be there just as much and this PR is IMO massive enough to merit finishing it first before attempting a switch to rattler-build. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)