Clean up more disk space #1747
Merged
Clean up more disk space #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Jul 21, 2023
isuruf
requested changes
Jul 21, 2023
|
Yeah was wondering the same thing. If it does take a long time, it might be worth looking at |
|
Also we could look at using a different method to delete to save time |
|
Or a |
|
Here is a log file for the steps, but the summary is |
jakirkham
reviewed
Jul 21, 2023
|
I'll try timing the other way of deleting. Here are the directory sizes. |
|
|
|
Might be worth confirming that |
|
Sure, I have the final timing logs with a To summarize, for this run
The final free disk space is ~ 49 GB which is less than what I saw earlier (~ 60 GB). Maybe there was an image update that rolled through? The other consideration is that a failure in this step should not stop the build. The |
|
Before the last image update there was 30GB left and after the image update there's only 23 GB left. Can we only do the rsync part? |
|
Thanks Billy! 🙏 Appreciate your effort in exploring this issue Yeah believe there were image updates. Though haven't looked to see if there was a blogpost, release notes, or something about these. Shaving off 10GB is pretty worthwhile in my book (especially given the amount of time spent is pretty low) In terms of ignoring missing directories we could do |
jakirkham
reviewed
Jul 21, 2023
jakirkham
reviewed
Jul 21, 2023
jakirkham
approved these changes
Jul 21, 2023
|
cc @conda-forge/core (in case others have thoughts) |
|
Thanks everyone! |
|
@isuruf are you ok merging this? |
mikemhenry
reviewed
Jul 22, 2023
Yes |
Co-authored-by: Mike Henry <[email protected]>
mbargull
requested changes
Jul 22, 2023
There was a problem hiding this comment.
-
Can we add some reference to the PR's OP?
It's always good to have a (ideally very succinct) problem/motivation description with a (hyperlink) reference;
À laFixes disk space issues encountered at <links to feedstocks/builds>. -
I think we should only do this for the directories that get deleted with high throughput (acc. to numbers from Clean up more disk space #1747 (comment) and Clean up more disk space #1747 (comment) ) i.e.,
/usr/local/lib/android/usr/local/share/powershell- (
/usr/lib/jvmand/usr/share/swiftif need be)
-
Do we have elapsed time numbers for
/opt/hostedtoolcache/CodeQL/alone? Since that appears to be the largest of/opt/hostedtoolcache, it could make sense to only delete that one if it's faster to remove than all of its parent directory.
The limited disk space only affects a very small fraction of builds which is why it would create a lot of "unneeded busy work" for nearly all feedstocks. Hence we should be a bit more conservative w.r.t. the time taken here.
|
It'd also be good to get numbers for disk space freed and time needed (for each of the removed directories) for the final version of this PR. |
|
I think the suggestion of having a switch to enable the deletion would be a win-win, rather than having to find a balance between some feedstocks that don't build at all, and wasting time for disk clean-up on every feedstock. For affected feedstocks, it doesn't matter if it takes minutes to do the most extensive clean-up (if the alternative is a failing build), and with a switch we wouldn't pay that cost anywhere else. |
|
@h-vetinari, I agree in principle and that was my first thought too. It is a matter of finding a pragmatic balance. (That being said, if some builds are so wildly inefficient that they still need "moar", we might at some point need such an option... or fix the builds (upstream)... 🤷) |
|
Guys, we're bike shedding this one a bit. Let's add a switch to turn this on or off and then move on. We can revisit later if we want to do something more detailed. |
My intention was to avoid much bike shedding by going with a "simple and non-negative impacting but sufficient" route.
If you/others (since, to be frank, I won't be the one documenting/maintaining it) are okay with that, fine by me, of course! |
beckermr
approved these changes
Jul 22, 2023
|
thanks all! excited to see if this helps avoid some disk full issues we saw on qt! |
|
Thanks all! 🙏 For clarity the There's also a bunch of logs above that Billy generated if you're interested in more details That said, adding a switch makes sense |
|
I can also make a PR to update the documentation. Is the switch a new field in the |
|
Yes! A doc pr would be excellent! Thank you! |
This was referenced Jul 24, 2023
Merged
1 task
bkpoon
added a commit
to bkpoon/conda-forge.github.io
that referenced
this pull request
Jul 24, 2023
bkpoon
added a commit
to bkpoon/conda-forge.github.io
that referenced
this pull request
Jul 24, 2023
|
Docs added in PR ( conda-forge/conda-forge.github.io#1986 ) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentryThis frees up more disk space on the linux image. Items for deletion are taken from
https://github.com/easimon/maximize-build-space
https://github.com/choderalab/espaloma/pull/176/files#diff-17e3400d876978d12bbad517dcf82312b54fa62723408b1ce011b2755458bdafR36-R62
For reference, the linux image (
ubuntu-22.04) contains software listed in https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md