-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reinstate basic cleanup if azure.free_disk_space
is False
#1750
Conversation
The |
Ah, my bad then, I had not caught that detail in #1747. Sorry for the noise. |
Oh no worries at all! If that directory is not actually empty then this PR would be useful. This is also related to @mbargull's idea of doing some fast clean-up all the time. |
The |
Let me re-run the timings again and provide the size of each directory. A subset of directories could be cleaned by default. |
Sure though I think if we are in the |
Here are the sizes and times. The full timing log is copied below (the directory sizes were run separately since running
It's not clear why Full timing log
|
I noticed in a feedstock I just rerendered with conda-smithy 3.24.1 that it does:
I cannot read @beckermr's mind about his intention in #1747; it's possible to argue that we can avoid the deletion of
/opt/ghc
- however fast - for all feedstocks that don't need it, but the deletion of the more basic disk space handling could also have been an unintentional side-effect of introducing theazure.free_disk_space
option.CC @beckermr @bkpoon @isuruf @jakirkham