Add wUSDM as collateral to USDT market on Optimism #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ware/comet into woof-software/add-wusdm-to-optimism-usdt
| combinedScale = signed256(10 ** (rateProviderDecimals + underlyingDecimals)); | ||
| description = description_; | ||
|
|
||
| if (decimals_ > 18) revert BadDecimals(); |
There was a problem hiding this comment.
nit: having this comparison at the beginning might be better for readability
| uint256 rate = IERC4626(rateProvider).convertToAssets(10**rateProviderDecimals); | ||
| (uint80 roundId_, int256 underlyingPrice, uint256 startedAt_, uint256 updatedAt_, uint80 answeredInRound_) = AggregatorV3Interface(underlyingPriceFeed).latestRoundData(); | ||
|
|
||
| if (rate <= 0 || underlyingPrice <= 0) return (roundId_, 0, startedAt_, updatedAt_, answeredInRound_); |
There was a problem hiding this comment.
nit: since rate is unit256, == can be used instead of <= to avoid misunderstand.
…ware/comet into woof-software/add-wusdm-to-optimism-usdt
…are/add-wusdm-to-optimism-usdt
vitalii-woof-software
force-pushed
the
woof-software/add-wusdm-to-optimism-usdt
branch
2 times, most recently
from
b404262
to
7e4a0f3
Compare
vitalii-woof-software
force-pushed
the
woof-software/add-wusdm-to-optimism-usdt
branch
from
7e4a0f3
to
6116139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.