Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): block events to viewer when measurement tool is active #3616

Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Aug 24, 2023

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1291

Description 📝

Measurement tool now blocks pointerdown events targeted at the viewer canvas to prevent click events in viewer when measuring.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner August 24, 2023 11:56
@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #3616 (e1144f4) into master (50abee3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3616      +/-   ##
==========================================
- Coverage   71.68%   71.66%   -0.02%     
==========================================
  Files         346      346              
  Lines       33669    33673       +4     
  Branches     2643     2641       -2     
==========================================
- Hits        24135    24133       -2     
- Misses       9430     9436       +6     
  Partials      104      104              
Files Changed Coverage Δ
.../packages/tools/src/Measurement/MeasurementTool.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

christjt
christjt previously approved these changes Aug 24, 2023
@haakonflatval-cognite haakonflatval-cognite changed the title fix: block events to viewer when measurement tool is active fix(viewer): block events to viewer when measurement tool is active Aug 24, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit ab563ea into master Aug 24, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/block-events-in-measurement-tool branch August 24, 2023 12:36
haakonflatval-cognite added a commit that referenced this pull request Sep 22, 2023
haakonflatval-cognite added a commit that referenced this pull request Sep 22, 2023
* Revert "fix(viewer): only do measurement on canvas (#3636)"

This reverts commit 1dae829.

* Revert "fix(viewer): block events to viewer when measurement tool is active (#3616)"

This reverts commit ab563ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants