Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert measurement blocking #3727

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Sep 22, 2023

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/REV-990

Description 📝

Recent changes in measurement tool interaction (#3616, #3636) removed the capability to move the camera while in measurement mode. This capability will be restored with this PR, but will simultaneously revert the feature where the measurement tool would block click events triggering on models from other listeners. That feature will be re-introduced with #3726 in a new minor version

How has this been tested? 🔍

In examples

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 22, 2023 09:08
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #3727 (554aca7) into master (54b7489) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3727   +/-   ##
=======================================
  Coverage   71.70%   71.71%           
=======================================
  Files         346      346           
  Lines       33766    33760    -6     
  Branches     2652     2652           
=======================================
- Hits        24212    24210    -2     
+ Misses       9446     9442    -4     
  Partials      108      108           
Files Changed Coverage Δ
.../packages/tools/src/Measurement/MeasurementTool.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@haakonflatval-cognite haakonflatval-cognite merged commit 539068a into master Sep 22, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/revert-measurement-blocking branch September 22, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants