refactor(Marketplace): Use custom errors instead of string messages #141
+152
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emizzle
approved these changes
Aug 6, 2024
deployments/taiko_test/solcInputs/9671d4e1820229dcd69b349a99feb65b.json
Outdated
Show resolved
Hide resolved
|
Btw. please don't merge it until we have |
0x-r4bbit
force-pushed
the
custom-errors
branch
from
cc2d0b0 to
576fefe
Compare
|
Addressed all comments made here and updated the PR. |
This reduces the gas cost as custom errors always use 4 bytes.
AuHau
added
the
Marketplace
|
At last! |
Haha yeah 😅 After half year... 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the gas cost as custom errors always use 4 bytes.
This supersedes #73 as we need PRs to be sent from upstream repository in order to have the verification task work on CI.