refactor: marketplace custom errors handling #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspanbroek
approved these changes
Jan 13, 2025
emizzle
approved these changes
Jan 14, 2025
tests/contracts/testContracts.nim
Outdated
| .markProofAsMissing(slotId, missingPeriod) | ||
| .confirm(1) | ||
| .reverts("Slot not accepting proofs") | ||
| try: |
There was a problem hiding this comment.
This test doesn't really cover the changes introduced, although I don't know how much we really want to cover all of them. We could add a test that calls requestState with a non-existent requestId, which should return none RequestState.
AuHau
force-pushed
the
refactor/marketplace-custom-errors
branch
from
f66e88e to
4bc661b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for codex-storage/codex-contracts-eth#141