-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[김민찬] Sprint8 #247
Merged
lisarnjs
merged 18 commits into
codeit-bootcamp-frontend:React-김민찬
from
itscold96:React-김민찬-sprint8
Aug 5, 2024
The head ref may contain hidden characters: "React-\uAE40\uBBFC\uCC2C-sprint8"
Merged
[김민찬] Sprint8 #247
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
07384bb
fix: 프로젝트 내 오타 수정
itscold96 98ae7fd
fix(Product): 상품 이미지가 공간을 다 채우지 않는 문제 해결
itscold96 aaa59e4
refactor(mentor): 미디어쿼리 사이즈 변화 문자열 상수화
itscold96 e0c9bac
fix: 오타 수정
itscold96 c559e68
refactor(useValidForm): 기존 useValidForm을 기능별로 분리
itscold96 9686e42
rename(formStyles): 유효성 검사를 위한 프로퍼티명을 직관적으로 수정
itscold96 ef21410
docs: validType 타입 관련 주석 추가
itscold96 ef38cec
rename: 핸들러 함수 이름 수정
itscold96 628a121
refactor(LoginForm): 기존 커스텀 훅을 모아 로그인 폼 용 커스텀 훅 제작
itscold96 2072eab
refactor(SignupForm): 기존 커스텀 훅을 모아 회원가입 폼 용 커스텀 훅 제작
itscold96 760dccc
remove(useValidForm): 리팩토링하여 더 이상 사용하지 않는 useValidForm 삭제
itscold96 354a4a1
rename(AddProduct): 변수 및 함수명을 좀더 직관적으로 수정
itscold96 71fb2e8
fix(Login): import 경로 수정
itscold96 0f4f4b7
move: form 관련 hook들을 hooks/form 폴더로 옮김
itscold96 26571c6
refactor: 불필요한 useNavigateTo 커스텀 훅 제거 및 Link로 교체
itscold96 64b3b3d
docs(useDidMountEffect): 주석 내용 수정
itscold96 27cd021
fix: 임포트 경로 수정
itscold96 ddcb0af
refactor(useLoginForm, useSignupForm): 불필요한 useEffect 제거
itscold96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
{} | ||
{ | ||
"cSpell.words": ["ADDITEM", "kakao", "Signup", "uuidv"] | ||
} |
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
src/ constants/infomations/addItemList.ts → src/ constants/information/addItemList.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export const DEVICE_MAX_WIDTH = { | ||
tablet: 1280, | ||
mobile: 768, | ||
}; | ||
|
||
export const MEDIA_QUERY_SIZE = { | ||
desktop: `(min-width: ${DEVICE_MAX_WIDTH.tablet}px)`, | ||
tablet: `(min-width: ${DEVICE_MAX_WIDTH.mobile}px) and (max-width: ${DEVICE_MAX_WIDTH.tablet}px)`, | ||
underTablet: `(max-width: ${DEVICE_MAX_WIDTH.tablet}px)`, | ||
mobile: `(max-width: ${DEVICE_MAX_WIDTH.mobile}px)`, | ||
}; |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확실히 사용하는 것도 덜 귀찮아지고, 직관적이여서 좋네요 👍