Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[김민찬] Sprint8 #247

Merged
merged 18 commits into from
Aug 5, 2024
Merged

[김민찬] Sprint8 #247

merged 18 commits into from
Aug 5, 2024

Commits on Jul 30, 2024

  1. fix: 프로젝트 내 오타 수정

    @itscold96
    itscold96 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    07384bb View commit details
    Browse the repository at this point in the history

  2. fix(Product): 상품 이미지가 공간을 다 채우지 않는 문제 해결

    @itscold96
    itscold96 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    98ae7fd View commit details
    Browse the repository at this point in the history

  3. refactor(mentor): 미디어쿼리 사이즈 변화 문자열 상수화

    @itscold96
    itscold96 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    aaa59e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. fix: 오타 수정 

    unvalid -> invalid
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e0c9bac View commit details
    Browse the repository at this point in the history

  2. refactor(useValidForm): 기존 useValidForm을 기능별로 분리 

    useValidForm을 useEmail, useNickname, usePassword, useVerifyPassword로 분리
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c559e68 View commit details
    Browse the repository at this point in the history

  3. rename(formStyles): 유효성 검사를 위한 프로퍼티명을 직관적으로 수정 

    is- 접두사는 boolean 값을 반환할 거라 기대하기 마련인데
실제로 boolean값이 아닌 값이 들어오고 있었기 때문에,
$validType으로 변경
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9686e42 View commit details
    Browse the repository at this point in the history

  4. docs: validType 타입 관련 주석 추가

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ef21410 View commit details
    Browse the repository at this point in the history

  5. rename: 핸들러 함수 이름 수정 

    이벤트의 종류가 뒤로 가도록 수정
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ef38cec View commit details
    Browse the repository at this point in the history

  6. refactor(LoginForm): 기존 커스텀 훅을 모아 로그인 폼 용 커스텀 훅 제작 

    useEmail, usePassword 커스텀 훅을 합하여 로그인 폼에 쓰일 커스텀 훅 제작
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    628a121 View commit details
    Browse the repository at this point in the history

  7. refactor(SignupForm): 기존 커스텀 훅을 모아 회원가입 폼 용 커스텀 훅 제작 

    useEmail, usePassword, useNickname, useVerifyPassword 를 모아 회원가입용 커스텀훅을 제작
    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    2072eab View commit details
    Browse the repository at this point in the history

  8. remove(useValidForm): 리팩토링하여 더 이상 사용하지 않는 useValidForm 삭제

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    760dccc View commit details
    Browse the repository at this point in the history

  9. rename(AddProduct): 변수 및 함수명을 좀더 직관적으로 수정

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    354a4a1 View commit details
    Browse the repository at this point in the history

  10. fix(Login): import 경로 수정

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    71fb2e8 View commit details
    Browse the repository at this point in the history

  11. move: form 관련 hook들을 hooks/form 폴더로 옮김

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0f4f4b7 View commit details
    Browse the repository at this point in the history

  12. refactor: 불필요한 useNavigateTo 커스텀 훅 제거 및 Link로 교체

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    26571c6 View commit details
    Browse the repository at this point in the history

  13. docs(useDidMountEffect): 주석 내용 수정

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    64b3b3d View commit details
    Browse the repository at this point in the history

  14. fix: 임포트 경로 수정

    @itscold96
    itscold96 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    27cd021 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. refactor(useLoginForm, useSignupForm): 불필요한 useEffect 제거 

    리팩토링 과정 중에 잔재하던 불필요한 useEffect 제거
    @itscold96
    itscold96 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ddcb0af View commit details
    Browse the repository at this point in the history