-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FYST-545-add-maryland-address-screen-and-data-model-to-md #4927
Merged
DrewProebstel
merged 15 commits into
main
from
FYST-545-add-maryland-address-screen-and-data-model-to-md
Nov 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
25d882f
wip
51eac74
add missing enum
53ac3b3
merge main
58fc7b8
update es.yml and complete intake spec
d4c6ce8
zipcode validator ignores dashes
67f70ad
annotate
2f9d390
fix cappyberra
a742208
Merge branch 'main' into FYST-545-add-maryland-address-screen-and-dat…
e8c2297
restore md intake
383f651
update zipcode validator
ea7723c
add missing newline
1b3babc
add permanent address outside md enum
66cf5de
return to review concern
1a53614
merge main
a582f9b
update page order
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 1 addition & 2 deletions
3
app/controllers/state_file/questions/md_permanent_address_controller.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
module StateFile | ||
module Questions | ||
class MdPermanentAddressController < QuestionsController | ||
include ReturnToReviewConcern | ||
include EligibilityOffboardingConcern | ||
|
||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -33,7 +33,7 @@ | |||||||
# locked_at :datetime | ||||||||
# message_tracker :jsonb | ||||||||
# payment_or_deposit_type :integer default("unfilled"), not null | ||||||||
# permanent_address_outside_md :integer default(0), not null | ||||||||
# permanent_address_outside_md :integer default("unfilled"), not null | ||||||||
# permanent_apartment :string | ||||||||
# permanent_city :string | ||||||||
# permanent_street :string | ||||||||
|
@@ -98,6 +98,7 @@ class StateFileMdIntake < StateFileBaseIntake | |||||||
enum eligibility_homebuyer_withdrawal_mfj: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_homebuyer_withdrawal_mfj | ||||||||
enum eligibility_home_different_areas: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_home_different_areas | ||||||||
enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
enum permanent_address_outside_md: { unfilled: 0, yes: 1, no: 2 }, _prefix: :permanent_address_outside_md | ||||||||
|
||||||||
|
||||||||
def disqualifying_df_data_reason | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I think you'll still need
include ReturnToReviewConcern
though