Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-545-add-maryland-address-screen-and-data-model-to-md #4927

Merged
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
module StateFile
module Questions
class MdPermanentAddressController < QuestionsController
include ReturnToReviewConcern
include EligibilityOffboardingConcern

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I think you'll still need include ReturnToReviewConcern though

end
end
end
3 changes: 2 additions & 1 deletion app/models/state_file_md_intake.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# locked_at :datetime
# message_tracker :jsonb
# payment_or_deposit_type :integer default("unfilled"), not null
# permanent_address_outside_md :integer default(0), not null
# permanent_address_outside_md :integer default("unfilled"), not null
# permanent_apartment :string
# permanent_city :string
# permanent_street :string
Expand Down Expand Up @@ -98,6 +98,7 @@ class StateFileMdIntake < StateFileBaseIntake
enum eligibility_homebuyer_withdrawal_mfj: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_homebuyer_withdrawal_mfj
enum eligibility_home_different_areas: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_home_different_areas
enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address
enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address
enum permanent_address_outside_md: { unfilled: 0, yes: 1, no: 2 }, _prefix: :permanent_address_outside_md

enum permanent_address_outside_md: { unfilled: 0, yes: 1, no: 2 }, _prefix: :permanent_address_outside_md


def disqualifying_df_data_reason
Expand Down
12 changes: 1 addition & 11 deletions spec/factories/state_file_md_intakes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# locked_at :datetime
# message_tracker :jsonb
# payment_or_deposit_type :integer default("unfilled"), not null
# permanent_address_outside_md :integer default(0), not null
# permanent_address_outside_md :integer default("unfilled"), not null
# permanent_apartment :string
# permanent_city :string
# permanent_street :string
Expand Down Expand Up @@ -124,16 +124,6 @@
spouse_last_name { "Lando" }
end

factory :state_file_md_refund_intake do
after(:build) do |intake, evaluator|
intake.direct_file_data.fed_wages = 2_000
intake.direct_file_data.fed_taxable_income = 2_000
intake.direct_file_data.fed_taxable_ssb = 0
intake.direct_file_data.fed_unemployment = 0
intake.raw_direct_file_data = intake.direct_file_data.to_s
end
end

trait :df_data_2_w2s do
raw_direct_file_data { StateFile::DirectFileApiResponseSampleService.new.read_xml('md_zeus_two_w2s') }
end
Expand Down
2 changes: 1 addition & 1 deletion spec/models/state_file_md_intake_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# locked_at :datetime
# message_tracker :jsonb
# payment_or_deposit_type :integer default("unfilled"), not null
# permanent_address_outside_md :integer default(0), not null
# permanent_address_outside_md :integer default("unfilled"), not null
# permanent_apartment :string
# permanent_city :string
# permanent_street :string
Expand Down
Loading