FYST-545-add-maryland-address-screen-and-data-model-to-md #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewProebstel
changed the title
|
Heroku app: https://gyr-review-app-4927-987f2c261dd1.herokuapp.com/ |
added 7 commits
October 30, 2024 09:06
embarnard
requested changes
Oct 31, 2024
app/controllers/state_file/questions/md_permanent_address_controller.rb
Outdated
Show resolved
Hide resolved
| @@ -91,6 +97,7 @@ class StateFileMdIntake < StateFileBaseIntake | |||
| enum eligibility_homebuyer_withdrawal: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_homebuyer_withdrawal | |||
| enum eligibility_homebuyer_withdrawal_mfj: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_homebuyer_withdrawal_mfj | |||
| enum eligibility_home_different_areas: { unfilled: 0, yes: 1, no: 2 }, _prefix: :eligibility_home_different_areas | |||
| enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address | |||
There was a problem hiding this comment.
Suggested change
| enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address | |
| enum confirmed_permanent_address: { unfilled: 0, yes: 1, no: 2 }, _prefix: :confirmed_permanent_address | |
| enum permanent_address_outside_md: { unfilled: 0, yes: 1, no: 2 }, _prefix: :permanent_address_outside_md |
| @@ -118,6 +124,16 @@ | |||
| spouse_last_name { "Lando" } | |||
| end | |||
|
|
|||
| factory :state_file_md_refund_intake do | |||
There was a problem hiding this comment.
Why do you need this factory case? And if you do need i would advise adding it as a trait instead so it would build or overwrite the base intake something more like:
Suggested change
| factory :state_file_md_refund_intake do | |
| trait :with_refund do | |
| after(:build) do |intake, evaluator| | |
| intake.direct_file_data.fed_wages = 2_000 | |
| intake.direct_file_data.fed_taxable_income = 2_000 | |
| intake.direct_file_data.fed_taxable_ssb = 0 | |
| intake.direct_file_data.fed_unemployment = 0 | |
| end | |
| end |
embarnard
requested changes
Nov 1, 2024
| @@ -1,8 +1,7 @@ | |||
| module StateFile | |||
| module Questions | |||
| class MdPermanentAddressController < QuestionsController | |||
| include ReturnToReviewConcern | |||
| include EligibilityOffboardingConcern | |||
|
|
|||
There was a problem hiding this comment.
Sorry I think you'll still need include ReturnToReviewConcern though
added 2 commits
November 1, 2024 09:41
embarnard
approved these changes
Nov 1, 2024
DrewProebstel
deleted the
FYST-545-add-maryland-address-screen-and-data-model-to-md
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?