-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused source member from an iorule in DataFormats/TauReco/src/classes_def_2.xml #47214
Conversation
With ROOT master the two io read rules having jetRef_ source are in conflict, and this iorule does not seem to make any use of it.
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47214/43497 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
-1 Failed Tests: HeaderConsistency UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
|
Header consistency failure comes from inclusion of #47190 in the tests |
ignore tests-rejected with manual-override |
Comparison differences are related to #47071 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Suggested in cms-sw/cmsdist#9643 (comment) to address a test failure in a PR updating ROOT master.
Resolves cms-sw/framework-team#1206
PR validation:
None