Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOTMaster] Updated root to tip of branch master #9643

Open
wants to merge 3 commits into
base: IB/CMSSW_15_0_X/rootmaster
Choose a base branch
from

Conversation

iarspider
Copy link
Contributor

Supersedes #9627

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_15_0_X/rootmaster.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2025

cms-bot internal usage

@iarspider iarspider changed the title Updated root to tip of branch master [ROOTMaster] Updated root to tip of branch master Jan 29, 2025
@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44013/summary.html
COMMIT: 70602d0
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9643/44013/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44013/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44013/git-merge-result

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/DataFormats/TrackReco/src/classes.h
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/bin/rootcling -reflex -f tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -inlineInputHeader -failOnWarnings -rmf tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.rootmap -rml libDataFormatsTrackReco.so -m DataFormatsTrackCandidate_xr_rdict.pcm -m DataFormatsTrajectorySeed_xr_rdict.pcm -m DataFormatsTrackingRecHit_xr_rdict.pcm -m DataFormatsTrackerCommon_xr_rdict.pcm -m DataFormatsBeamSpot_xr_rdict.pcm -m DataFormatsGeometryCommonDetAlgo_xr_rdict.pcm -m DataFormatsSiStripCluster_xr_rdict.pcm -m DataFormatsCandidate_xr_rdict.pcm -m DataFormatsGeometrySurface_xr_rdict.pcm -m DataFormatsTrajectoryState_xr_rdict.pcm -m DataFormatsCLHEP_xr_rdict.pcm -m DataFormatsForwardDetId_xr_rdict.pcm -m DataFormatsGeometryVector_xr_rdict.pcm -m DataFormatsMuonDetId_xr_rdict.pcm -m DataFormatsSiPixelDetId_xr_rdict.pcm -m DataFormatsSiStripDetId_xr_rdict.pcm -m DataFormatsDetId_xr_rdict.pcm -m DataFormatsMath_xr_rdict.pcm -m DataFormatsScouting_xr_rdict.pcm -m DataFormatsSiPixelCluster_xr_rdict.pcm -m DataFormatsSiStripDigi_xr_rdict.pcm -m DataFormatsCommon_xr_rdict.pcm -m DataFormatsProvenance_xr_rdict.pcm -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -DCMS_MICRO_ARCH="x86-64-v3" -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ROOT6_X_2025-01-28-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT src/DataFormats/TrackReco/src/classes.h src/DataFormats/TrackReco/src/classes_def.xml
>> Compiling  LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.d -I. -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ROOT6_X_2025-01-28-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -Os -Wno-unused-variable -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -o tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.o
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc: In function 'void ROOT::read_recocLcLHitPattern_0(char*, TVirtualObject*)':
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2698:96: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2698 |             (void) reco::HitPattern::fillNewHitPatternWithOldHitPattern_v12(onfile.hitPattern, *onfile.hitCount,
      |                                                                                                ^~~~~~~~~~~~~~~~
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2699:21: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2699 |                     *onfile.beginTrackHits, *onfile.endTrackHits,
      |                     ^~~~~~~~~~~~~~~~~~~~~~


@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44020/summary.html
COMMIT: 70602d0
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9643/44020/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44020/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44020/git-merge-result

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/DataFormats/TrackReco/src/classes.h
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/bin/rootcling -reflex -f tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -inlineInputHeader -failOnWarnings -rmf tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.rootmap -rml libDataFormatsTrackReco.so -m DataFormatsTrackCandidate_xr_rdict.pcm -m DataFormatsTrajectorySeed_xr_rdict.pcm -m DataFormatsTrackingRecHit_xr_rdict.pcm -m DataFormatsTrackerCommon_xr_rdict.pcm -m DataFormatsBeamSpot_xr_rdict.pcm -m DataFormatsGeometryCommonDetAlgo_xr_rdict.pcm -m DataFormatsSiStripCluster_xr_rdict.pcm -m DataFormatsCandidate_xr_rdict.pcm -m DataFormatsGeometrySurface_xr_rdict.pcm -m DataFormatsTrajectoryState_xr_rdict.pcm -m DataFormatsCLHEP_xr_rdict.pcm -m DataFormatsForwardDetId_xr_rdict.pcm -m DataFormatsGeometryVector_xr_rdict.pcm -m DataFormatsMuonDetId_xr_rdict.pcm -m DataFormatsSiPixelDetId_xr_rdict.pcm -m DataFormatsSiStripDetId_xr_rdict.pcm -m DataFormatsDetId_xr_rdict.pcm -m DataFormatsMath_xr_rdict.pcm -m DataFormatsScouting_xr_rdict.pcm -m DataFormatsSiPixelCluster_xr_rdict.pcm -m DataFormatsSiStripDigi_xr_rdict.pcm -m DataFormatsCommon_xr_rdict.pcm -m DataFormatsProvenance_xr_rdict.pcm -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -DCMS_MICRO_ARCH="x86-64-v3" -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT src/DataFormats/TrackReco/src/classes.h src/DataFormats/TrackReco/src/classes_def.xml
>> Compiling  LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.d -I. -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -Os -Wno-unused-variable -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -o tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.o
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc: In function 'void ROOT::read_recocLcLHitPattern_0(char*, TVirtualObject*)':
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2698:96: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2698 |             (void) reco::HitPattern::fillNewHitPatternWithOldHitPattern_v12(onfile.hitPattern, *onfile.hitCount,
      |                                                                                                ^~~~~~~~~~~~~~~~
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2699:21: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2699 |                     *onfile.beginTrackHits, *onfile.endTrackHits,
      |                     ^~~~~~~~~~~~~~~~~~~~~~


@smuzaffar
Copy link
Contributor

@iarspider , can you please follow up the build errors?

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#47202

@iarspider
Copy link
Contributor Author

iarspider commented Jan 29, 2025

@pcanal we still see issues with ROOT dictionaries, see #9643 (comment) .

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#47202 for CMSSW_15_0_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44037/summary.html
COMMIT: 70602d0
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9643/44037/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44037/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44037/git-merge-result

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/DataFormats/TrackReco/src/classes.h
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/bin/rootcling -reflex -f tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -inlineInputHeader -failOnWarnings -rmf tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.rootmap -rml libDataFormatsTrackReco.so -m DataFormatsTrackCandidate_xr_rdict.pcm -m DataFormatsTrajectorySeed_xr_rdict.pcm -m DataFormatsTrackingRecHit_xr_rdict.pcm -m DataFormatsTrackerCommon_xr_rdict.pcm -m DataFormatsBeamSpot_xr_rdict.pcm -m DataFormatsGeometryCommonDetAlgo_xr_rdict.pcm -m DataFormatsSiStripCluster_xr_rdict.pcm -m DataFormatsCandidate_xr_rdict.pcm -m DataFormatsGeometrySurface_xr_rdict.pcm -m DataFormatsTrajectoryState_xr_rdict.pcm -m DataFormatsCLHEP_xr_rdict.pcm -m DataFormatsForwardDetId_xr_rdict.pcm -m DataFormatsGeometryVector_xr_rdict.pcm -m DataFormatsMuonDetId_xr_rdict.pcm -m DataFormatsSiPixelDetId_xr_rdict.pcm -m DataFormatsSiStripDetId_xr_rdict.pcm -m DataFormatsDetId_xr_rdict.pcm -m DataFormatsMath_xr_rdict.pcm -m DataFormatsScouting_xr_rdict.pcm -m DataFormatsSiPixelCluster_xr_rdict.pcm -m DataFormatsSiStripDigi_xr_rdict.pcm -m DataFormatsCommon_xr_rdict.pcm -m DataFormatsProvenance_xr_rdict.pcm -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -DCMS_MICRO_ARCH="x86-64-v3" -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_15_0_ROOT6_X_2025-01-28-2300" -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT src/DataFormats/TrackReco/src/classes.h src/DataFormats/TrackReco/src/classes_def.xml
>> Compiling  LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.d -I. -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ROOT6_X_2025-01-28-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-753234bc33b783f751a1fe407d0a326a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-e3cd1bccca5fce4d98fce27bc9430717/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-23a8f217dd90c3188f6e2927e243d7db/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-de1d0edd23fc7bdc98ffd0075777fffa/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -Os -Wno-unused-variable -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc -o tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc.o
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc: In function 'void ROOT::read_recocLcLHitPattern_0(char*, TVirtualObject*)':
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2698:96: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2698 |             (void) reco::HitPattern::fillNewHitPatternWithOldHitPattern_v12(onfile.hitPattern, *onfile.hitCount,
      |                                                                                                ^~~~~~~~~~~~~~~~
tmp/el8_amd64_gcc12/src/DataFormats/TrackReco/src/DataFormatsTrackReco/lcgdict/DataFormatsTrackReco_xr.cc:2699:21: error: invalid type argument of unary '*' (have 'uint8_t' {aka 'unsigned char'})
 2699 |                     *onfile.beginTrackHits, *onfile.endTrackHits,
      |                     ^~~~~~~~~~~~~~~~~~~~~~


@hahnjo
Copy link
Contributor

hahnjo commented Jan 30, 2025

As far as I understand, root-project/root#17523 fixes a long-standing issue that is present in released versions of ROOT so far. Before recent changes, it only affected the argument variable types so that

source="uint16_t hitPattern[50]; uint8_t hitCount; uint8_t beginTrackHits; uint8_t endTrackHits;uint8_t beginInner; uint8_t endInner; uint8_t beginOuter; uint8_t endOuter;"

gets generated with onfile.hitCount of type uint8_t[50] while now it's (correctly!) uint8_t. The right solution would be to remove the incorrect dereferences, but this won't work with the version of ROOT that is used in production. For that specific rule involving fillNewHitPatternWithOldHitPattern_v12, you could try reordering the sources as uint8_t hitCount; uint8_t beginTrackHits; uint8_t endTrackHits;uint8_t beginInner; uint8_t endInner; uint8_t beginOuter; uint8_t endOuter;uint16_t hitPattern[50]; which should avoid the bug and allow to remove the dereferences even with older versions of ROOT. (If that's too cryptic of a description, I can try opening a PR for https://github.com/cms-sw/cmssw myself.)

@pcanal
Copy link

pcanal commented Feb 3, 2025

This problem was solved as a side effect of: root-project/root#17009 which has been merged in master (commit d63bac9820)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

Pull request #9643 was updated.

@smuzaffar
Copy link
Contributor

please test

thanks @pcanal , I have update this PR to use latest root master changes

@smuzaffar
Copy link
Contributor

@pcanal , the old data read unit test is still failing with

Thread 1 (Thread 0x1498a94d0580 (LWP 1162492) "cmsRun"):
#0  0x00001498a835cac1 in poll () from /lib64/libc.so.6
#1  0x00001498a41fdff7 in edm::service::InitRootHandlers::stacktraceFromThread() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#2  0x00001498a41fe1f4 in sig_dostack_then_abort () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#3  <signal handler called>
#4  0x00001498a31cf77b in TStreamerInfoActions::ReadViaExtStreamer (buf=..., addr=0x14987fe49490, config=0x14987fdfeec0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:297
#5  0x00001498a31944fd in TStreamerInfoActions::ReadStreamerCase (buf=..., addr=0x14987fe49490, config=0x14987fdfeec0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:314
#6  0x00001498a30a2779 in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14988029cf88, buffer=..., object=0x14987fe49490) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/inc/TStreamerInfoActions.h:123
#7  0x00001498a31d2b54 in TStreamerInfoActions::UseCache (b=..., addr=0x14988029ce24, conf=0x14988029cf60) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:1381
#8  0x00001498a30a2779 in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14987f1c4f20, buffer=..., object=0x14988029ce24) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/inc/TStreamerInfoActions.h:123
#9  0x00001498a30a057f in TBufferFile::ApplySequence (this=0x14987f1c40a0, sequence=..., obj=0x14988029ce24) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TBufferFile.cxx:3747
#10 0x00001498a309ffb4 in TBufferFile::ReadClassBuffer (this=0x14987f1c40a0, cl=0x14987f0a7600, pointer=0x14988029ce24, onFileClass=0x14987f0a7600) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TBufferFile.cxx:3666
#11 0x00001498a31946b1 in TStreamerInfoActions::ReadViaClassBuffer (buf=..., addr=0x14988029ce20, config=0x14987fe3be80) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:339
#12 0x00001498a31e0f38 in TStreamerInfoActions::VectorLooper::LoopOverCollection<&TStreamerInfoActions::ReadViaClassBuffer> (buf=..., start=0x14988029ce20, end=0x14988029ce70, loopconfig=0x14987fe2c800, config=0x14987fe3be80) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:2002
#13 0x00001498a30a27fd in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14987fe3bdc0, buffer=..., start_collection=0x14988029ce20, end_collection=0x14988029ce70, loopconf=0x14987fe2c800) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/inc/TStreamerInfoActions.h:131
#14 0x00001498a30a0882 in TBufferFile::ApplySequence (this=0x14987f1c40a0, sequence=..., start_collection=0x14988029ce20, end_collection=0x14988029ce70) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TBufferFile.cxx:3813
#15 0x00001498a31d0fd2 in TStreamerInfoActions::ReadSTLMemberWiseSameClass (buf=..., addr=0x14987f1cd3f0, conf=0x14987fe2b800, vers=9) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:805
#16 0x00001498a31d6679 in TStreamerInfoActions::ReadSTL<&TStreamerInfoActions::ReadSTLMemberWiseSameClass, &TStreamerInfoActions::ReadSTLObjectWiseFastArray> (buf=..., addr=0x14987f1cd3f0, conf=0x14987fe2b800) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:1163
#17 0x00001498a30a2779 in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14987fe2c6e0, buffer=..., object=0x14987f1cd3f0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/inc/TStreamerInfoActions.h:123
#18 0x00001498a30a057f in TBufferFile::ApplySequence (this=0x14987f1c40a0, sequence=..., obj=0x14987f1cd3f0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/io/io/src/TBufferFile.cxx:3747
#19 0x00001498a3797dfe in TBranchElement::ReadLeavesMember (this=0x14988195a700, b=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/tree/tree/src/TBranchElement.cxx:4568
#20 0x00001498a377d810 in TBranch::GetEntry (this=0x14988195a700, entry=0, getall=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/tree/tree/src/TBranch.cxx:1753
#21 0x00001498a3790e20 in TBranchElement::GetEntry (this=0x14988195a700, entry=0, getall=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-6f5cce328e43a1f5826b4fc57a769b0b/root-6.35.1/tree/tree/src/TBranchElement.cxx:2784
#22 0x00001498819cf73c in edm::RootTree::getEntry(TBranch*, long long) const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#23 0x00001498819cb5b2 in edm::FullProvenanceReader::readProvenance(unsigned int) const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#24 0x00001498819cc096 in void edm::SerialTaskQueueChain::actionToRun<edm::(anonymous namespace)::readProvenanceAsyncImpl<edm::FullProvenanceReader>(edm::FullProvenanceReader const*, edm::SerialTaskQueueChain&, edm::WaitingTaskHolder, unsigned int, std::atomic<std::set<edm::ProductProvenance, std::less<edm::ProductProvenance>, std::allocator<edm::ProductProvenance> > const*>&, edm::ModuleCallingContext const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*)::{lambda()#1}&>(edm::(anonymous namespace)::readProvenanceAsyncImpl<edm::FullProvenanceReader>(edm::FullProvenanceReader const*, edm::SerialTaskQueueChain&, edm::WaitingTaskHolder, unsigned int, std::atomic<std::set<edm::ProductProvenance, std::less<edm::ProductProvenance>, std::allocator<edm::ProductProvenance> > const*>&, edm::ModuleCallingContext const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*)::{lambda()#1}&) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#25 0x00001498819cc271 in edm::SerialTaskQueue::QueuedTask<edm::SerialTaskQueueChain::push<edm::(anonymous namespace)::readProvenanceAsyncImpl<edm::FullProvenanceReader>(edm::FullProvenanceReader const*, edm::SerialTaskQueueChain&, edm::WaitingTaskHolder, unsigned int, std::atomic<std::set<edm::ProductProvenance, std::less<edm::ProductProvenance>, std::allocator<edm::ProductProvenance> > const*>&, edm::ModuleCallingContext const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*)::{lambda()#1}>(tbb::detail::d1::task_group&, edm::(anonymous namespace)::readProvenanceAsyncImpl<edm::FullProvenanceReader>(edm::FullProvenanceReader const*, edm::SerialTaskQueueChain&, edm::WaitingTaskHolder, unsigned int, std::atomic<std::set<edm::ProductProvenance, std::less<edm::ProductProvenance>, std::allocator<edm::ProductProvenance> > const*>&, edm::ModuleCallingContext const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*, edm::signalslot::Signal<void (edm::StreamContext const&, edm::ModuleCallingContext const&)> const*)::{lambda()#1}&&)::{lambda()#1}>::execute() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#26 0x00001498a9bb8bd5 in tbb::detail::d1::function_task<edm::SerialTaskQueue::spawn(edm::SerialTaskQueue::TaskBase&)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/libFWCoreConcurrency.so
#27 0x00001498a9b153e1 in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x1498a65bbe00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.h:322
#28 tbb::detail::r1::task_dispatcher::local_wait_for_all<tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x1498a65bbe00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.h:458
#29 tbb::detail::r1::task_dispatcher::execute_and_wait (t=<optimized out>, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.cpp:168
#30 0x00001498a9748a7b in edm::FinalWaitingTask::wait() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#31 0x00001498a9756b61 in edm::EventProcessor::processRuns() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#32 0x00001498a9757011 in edm::EventProcessor::runToCompletion() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-02-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#33 0x0000000000408556 in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const ()
#34 0x00001498a9b019ad in tbb::detail::r1::task_arena_impl::execute (ta=..., d=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/arena.cpp:688
#35 0x000000000040a283 in main::{lambda()#1}::operator()() const ()

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44163/summary.html
COMMIT: 1d30452
CMSSW: CMSSW_15_0_ROOT6_X_2025-02-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9643/44163/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44163/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44163/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test testHeterogeneousCoreCUDATestWriteRead had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test TestPoolInputOldFormat had ERRORS

RelVals

  • 4.22A fatal system signal has occurred: segmentation violation
  • 1000.0A fatal system signal has occurred: segmentation violation
  • 1001.0A fatal system signal has occurred: segmentation violation

AddOn Tests

A fatal system signal has occurred: segmentation violation

@pcanal
Copy link

pcanal commented Feb 3, 2025

@smuzaffar What is the reproducer? Thanks.

@smuzaffar
Copy link
Contributor

same as #9643 (comment) but use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9643/44163/CMSSW_15_0_ROOT6_X_2025-02-02-2300

@pcanal
Copy link

pcanal commented Feb 3, 2025

I can reproduce #9643 (comment) in a standalone test, fix coming shortly.

@pcanal
Copy link

pcanal commented Feb 3, 2025

The fix is:

diff --git a/io/io/src/TStreamerInfo.cxx b/io/io/src/TStreamerInfo.cxx
index 81cd59b130..dff94b2c14 100644
--- a/io/io/src/TStreamerInfo.cxx
+++ b/io/io/src/TStreamerInfo.cxx
@@ -262,6 +262,7 @@ namespace {
       Int_t datasize = 1;
       auto memClass = TClass::GetClass(localtypename.c_str());
       std::vector<Int_t> dimensions;
+      static TClassRef string_classref("string");
       bool isStdArray = memClass && TClassEdit::IsStdArray(memClass->GetName());
       if (isStdArray) {
          totaldim = 1;
@@ -279,13 +280,13 @@ namespace {
          if (s->GetPointerLevel()) {
             if (memClass->IsTObject()) {
                memType = TVirtualStreamerInfo::kObjectP;
-            } else if (memClass->GetCollectionProxy()) {
+            } else if (memClass->GetCollectionProxy() || memClass == string_classref) {
                memType = TVirtualStreamerInfo::kSTLp;
             } else {
                memType = TVirtualStreamerInfo::kAnyP;
             }
          } else {
-            if (memClass->GetCollectionProxy()) {
+            if (memClass->GetCollectionProxy() || memClass == string_classref) {
                memType = TVirtualStreamerInfo::kSTL;
             } else if (memClass->IsTObject() && memClass == element->GetClassPointer()) {
                // If there is a change in the class type, we can't use the TObject::Streamer

@pcanal
Copy link

pcanal commented Feb 4, 2025

And the PR is root-project/root#17604

@smuzaffar
Copy link
Contributor

please test with cms-sw/root#216 for CMSSW_15_0_ROOT6_X

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 4, 2025

thanks @pcanal , root-project/root#17604 seems to fix most of the runtime errors. We still have couple of unit test failing with following errors.
You should be able to reproduce [b] by doing something like

> ssh lxplus
> source /cvmfs/cms.cern.ch/cmsset_default.sh
> cmssw-el8
> cd /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9643/44168/CMSSW_15_0_ROOT6_X_2025-02-03-2300
> cmsenv
> cd /tmp/$(whoami)
> cmsRun ${CMSSW_BASE}/src/HeterogeneousCore/CUDATest/test/writer.py
> cmsRun ${CMSSW_BASE}/src/HeterogeneousCore/CUDATest/test/reader.py    #this should fail

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44168/unitTests/src/PhysicsTools/PatAlgos/test/runtestPhysicsToolsPatAlgos/testing.log
CTPPSLocalTrackLite class dict is defined here https://github.com/cms-sw/cmssw/blob/master/DataFormats/CTPPSReco/src/classes_def.xml#L201

----- Begin Fatal Exception 04-Feb-2025 12:07:14 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  Event run: 1 lumi: 2 event: 54 stream: 0
   [1] Running path 'outpath'
   [2] Prefetching for module PoolOutputModule/'out'
   [3] While reading from source std::vector<CTPPSLocalTrackLite> ctppsLocalTrackLiteProducer '' RECO
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::InsertArtificialElements
For class CTPPSLocalTrackLite in StreamerInfo 3 is missing the source data member `tx` when trying to apply the rule:
   type=read sourceClass="CTPPSLocalTrackLite" targetClass="CTPPSLocalTrackLite" version="[3-4]" source="float tx" target="tx_" code="{tx_ = onfile.tx;}" 

----- End Fatal Exception -------------------------------------------------

[b] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44168/unitTests/src/HeterogeneousCore/CUDATest/test/testHeterogeneousCoreCUDATestWriteRead/testing.log

Tue Feb  4 11:52:44 CET 2025
Thread 2 (Thread 0x14b4c89ff700 (LWP 246585) "cmsRun"):
#0  0x000014b4ef131e42 in waitpid () from /lib64/libc.so.6
#1  0x000014b4eafbaf47 in edm::service::cmssw_stacktrace_fork() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#2  0x000014b4eafbddda in edm::service::InitRootHandlers::stacktraceHelperThread() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#3  0x000014b4ef4d8a73 in std::execute_native_thread_routine (__p=0x14b4caa80560) at ../../../../../libstdc++-v3/src/c++11/thread.cc:82
#4  0x000014b4ee9e81ca in start_thread () from /lib64/libpthread.so.0
#5  0x000014b4ef0638d3 in clone () from /lib64/libc.so.6
Thread 1 (Thread 0x14b4f02c9580 (LWP 244559) "cmsRun"):
#0  0x000014b4ef15cac1 in poll () from /lib64/libc.so.6
#1  0x000014b4eafbdff7 in edm::service::InitRootHandlers::stacktraceFromThread() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#2  0x000014b4eafbe1f4 in sig_dostack_then_abort () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#3  <signal handler called>
#4  0x000014b4ddaeb2ec in ROOT::read_cmscLcLcudacLcLPortableHostCollectionlEportabletestcLcLTestSoALayoutlE128cOfalsegRsPgR_0(char*, TVirtualObject*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libCUDADataFormatsPortableTestObjects.so
#5  0x000014b4ea0f16ad in TStreamerInfo::ReadBufferArtificial<char**> (this=this@entry=0x14b4c723ea40, b=..., arr=@0x7ffe4c06b670: 0x7ffe4c06b668, aElement=aElement@entry=0x14b4c723f680, narr=narr@entry=1, eoffset=eoffset@entry=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TStreamerInfoReadBuffer.cxx:560
#6  0x000014b4ea1b490e in TStreamerInfo::ReadBuffer<char**> (this=0x14b4c723ea40, b=..., arr=<optimized out>, compinfo=0x14b4b09aef88, first=<optimized out>, last=1, narr=1, eoffset=0, arrayMode=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TStreamerInfoReadBuffer.cxx:1728
#7  0x000014b4e9f943c4 in TStreamerInfoActions::GenericReadAction (buf=..., addr=0x14b4c723e968, config=0x14b4b09aef70) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:254
#8  0x000014b4e9ea2779 in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14b4c3a27520, buffer=..., object=0x14b4c723e968) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/inc/TStreamerInfoActions.h:123
#9  0x000014b4e9ea057f in TBufferFile::ApplySequence (this=0x14b4c9544b00, sequence=..., obj=0x14b4c723e968) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TBufferFile.cxx:3747
#10 0x000014b4e9e9ffb4 in TBufferFile::ReadClassBuffer (this=0x14b4c9544b00, cl=0x14b4c961a500, pointer=0x14b4c723e968, onFileClass=0x14b4c961a500) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TBufferFile.cxx:3666
#11 0x000014b4e9f947a1 in TStreamerInfoActions::ReadViaClassBuffer (buf=..., addr=0x14b4c723e960, config=0x14b4c7688100) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TStreamerInfoActions.cxx:339
#12 0x000014b4e9ea2779 in TStreamerInfoActions::TConfiguredAction::operator() (this=0x14b4ca942260, buffer=..., object=0x14b4c723e960) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/inc/TStreamerInfoActions.h:123
#13 0x000014b4e9ea057f in TBufferFile::ApplySequence (this=0x14b4c9544b00, sequence=..., obj=0x14b4c723e960) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/io/io/src/TBufferFile.cxx:3747
#14 0x000014b4ea597dfe in TBranchElement::ReadLeavesMember (this=0x14b4c7300000, b=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/tree/tree/src/TBranchElement.cxx:4568
#15 0x000014b4ea57d810 in TBranch::GetEntry (this=0x14b4c7300000, entry=0, getall=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/tree/tree/src/TBranch.cxx:1753
#16 0x000014b4ea590e20 in TBranchElement::GetEntry (this=0x14b4c7300000, entry=0, getall=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/tree/tree/src/TBranchElement.cxx:2784
#17 0x000014b4ea5909df in TBranchElement::GetEntry (this=0x14b4c70d5b00, entry=0, getall=0) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.35.1-f3384fc5e60dfe7fda57ea50db780aae/root-6.35.1/tree/tree/src/TBranchElement.cxx:2728
#18 0x000014b4c87cf73c in edm::RootTree::getEntry(TBranch*, long long) const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#19 0x000014b4c87aea58 in edm::RootDelayedReader::getProduct_(edm::BranchID const&, edm::EDProductGetter const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#20 0x000014b4f05331cb in edm::DelayedReader::getProduct(edm::BranchID const&, edm::EDProductGetter const*, edm::ModuleCallingContext const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#21 0x000014b4f05e4962 in edm::DelayedReaderInputProductResolver::prefetchAsync_(edm::WaitingTaskHolder, edm::Principal const&, bool, edm::ServiceToken const&, edm::SharedResourcesAcquirer*, edm::ModuleCallingContext const*) const::{lambda()#1}::operator()() const::{lambda()#1}::operator()() const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#22 0x000014b4f05e4b3c in edm::DelayedReaderInputProductResolver::prefetchAsync_(edm::WaitingTaskHolder, edm::Principal const&, bool, edm::ServiceToken const&, edm::SharedResourcesAcquirer*, edm::ModuleCallingContext const*) const::{lambda()#1}::operator()() const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#23 0x000014b4f05e4ba3 in edm::SerialTaskQueue::QueuedTask<edm::SerialTaskQueueChain::push<edm::DelayedReaderInputProductResolver::prefetchAsync_(edm::WaitingTaskHolder, edm::Principal const&, bool, edm::ServiceToken const&, edm::SharedResourcesAcquirer*, edm::ModuleCallingContext const*) const::{lambda()#1}&>(tbb::detail::d1::task_group&, edm::DelayedReaderInputProductResolver::prefetchAsync_(edm::WaitingTaskHolder, edm::Principal const&, bool, edm::ServiceToken const&, edm::SharedResourcesAcquirer*, edm::ModuleCallingContext const*) const::{lambda()#1}&)::{lambda()#1}>::execute() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#24 0x000014b4f094dbd5 in tbb::detail::d1::function_task<edm::SerialTaskQueue::spawn(edm::SerialTaskQueue::TaskBase&)::{lambda()#1}>::execute(tbb::detail::d1::execution_data&) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreConcurrency.so
#25 0x000014b4f08aa3e1 in tbb::detail::r1::task_dispatcher::local_wait_for_all<false, tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x14b4ed3bbe00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.h:322
#26 tbb::detail::r1::task_dispatcher::local_wait_for_all<tbb::detail::r1::external_waiter> (waiter=..., t=<optimized out>, this=0x14b4ed3bbe00) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.h:458
#27 tbb::detail::r1::task_dispatcher::execute_and_wait (t=<optimized out>, wait_ctx=..., w_ctx=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/task_dispatcher.cpp:168
#28 0x000014b4f0548a7b in edm::FinalWaitingTask::wait() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#29 0x000014b4f0556b61 in edm::EventProcessor::processRuns() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#30 0x000014b4f0557011 in edm::EventProcessor::runToCompletion() () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-02-03-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so
#31 0x0000000000408556 in tbb::detail::d1::task_arena_function<main::{lambda()#1}::operator()() const::{lambda()#1}, void>::operator()() const ()
#32 0x000014b4f08969ad in tbb::detail::r1::task_arena_impl::execute (ta=..., d=...) at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/tbb/v2021.9.0-63e1493f6c63f7899f38cf6d13a1d19f/tbb-v2021.9.0/src/tbb/arena.cpp:688
#33 0x000000000040a283 in main::{lambda()#1}::operator()() const ()
#34 0x00000000004051b8 in main ()

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44168/summary.html
COMMIT: 1d30452
CMSSW: CMSSW_15_0_ROOT6_X_2025-02-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9643/44168/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44168/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3e03/44168/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test testHeterogeneousCoreCUDATestWriteRead had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

Summary:

@pcanal
Copy link

pcanal commented Feb 4, 2025

@smuzaffar for (a) can I access the input file (or more exactly the StreamerInfo for the class CTPPSLocalTrackLite)?

I can reproduce (b) locally. I am investigating a solution.

@smuzaffar
Copy link
Contributor

@pcanal , the input file for [a] is available under my public afs area i.e. /afs/cern.ch/user/m/muzaffar/public/EEB99F74-DA4D-E711-A41C-0025905A48F2.root

@pcanal
Copy link

pcanal commented Feb 4, 2025

For (a), the file believes:

root [2] TClass::GetClass("CTPPSLocalTrackLite")->GetStreamerInfo()->ls()

StreamerInfo for class: CTPPSLocalTrackLite, version=3, checksum=0xe4cfa6d2
  unsigned int   rpId            offset=  8 type=13                     
  float          x               offset= 16 type= 5                     
  float          x_unc           offset= 24 type= 5                     
  float          y               offset= 32 type= 5                     
  float          y_unc           offset= 40 type= 5                     
  float          time            offset= 48 type= 5                     
  float          time_unc        offset= 56 type= 5                     

while there is a rule recorded as:

  <ioread sourceClass="CTPPSLocalTrackLite" version="[3-4]" targetClass="CTPPSLocalTrackLite" source="float tx" target="tx_">
  <![CDATA[tx_ = onfile.tx;]]>
  </ioread>

leading to the accurate warning:

      [a] Fatal Root Error: @SUB=TStreamerInfo::InsertArtificialElements
For class CTPPSLocalTrackLite in StreamerInfo 3 is missing the source data member `tx` when trying to apply the rule:
   type=read sourceClass="CTPPSLocalTrackLite" targetClass="CTPPSLocalTrackLite" version="[3-4]" source="float tx" target="tx_" code="{tx_ = onfile.tx;}" 

The rules needs to be adjusted or removed. I am not sure when the class had a tx member. For version (3) it looks like (according to cms-sw/cmssw@f944e0f) that it indeed did not. For version (4) (according https://github.com/cms-sw/cmssw/commit/745fef0d2b91fb372fd02dd86acf3dd274c71e26) there was a tx so, it look like the solution (for this rule are similar) is to use:

  <ioread sourceClass="CTPPSLocalTrackLite" version="[4]" targetClass="CTPPSLocalTrackLite" source="float tx" target="tx_">
  <![CDATA[tx_ = onfile.tx;]]>
  </ioread>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants