-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetTools
: do not run svClustering
for pfDeepCSV{*}TagInfos
#47052
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47052/43200 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
urgent
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title say it all.
PR #47045 introduced a
fillDescriptions
method forDeepNNTagInfoProducer
.This exposed the fact that, in the
addJetCollection
function, thesetupBTagging
function (responsible for handling b-tagging related configurations, includingfatJets
andgroomedFatJets
and other parameters) sets few parameters forDeepNNTagInfoProducer
which are not existing:cmssw/PhysicsTools/PatAlgos/python/tools/jetTools.py
Lines 231 to 239 in b5cf409
resulting in a failure of the test
runtestPhysicsToolsPatAlgos
(see for example this log).This PR fixes the issue by removing the
setupSVClustering
calls where unnecessary.PR validation:
scram b runtests_runtestPhysicsToolsPatAlgos
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A