Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetTools: do not run svClustering for pfDeepCSV{*}TagInfos #47052

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 7, 2025

PR description:

Title say it all.
PR #47045 introduced a fillDescriptions method for DeepNNTagInfoProducer.
This exposed the fact that, in the addJetCollection function, the setupBTagging function (responsible for handling b-tagging related configurations, including fatJets and groomedFatJets and other parameters) sets few parameters for DeepNNTagInfoProducer which are not existing:

def setupSVClustering(btagInfo, svClustering, algo, rParam, fatJets=cms.InputTag(''), groomedFatJets=cms.InputTag('')):
btagInfo.useSVClustering = cms.bool(svClustering)
btagInfo.jetAlgorithm = cms.string(algo)
btagInfo.rParam = cms.double(rParam)
## if the jet is actually a subjet
if fatJets != cms.InputTag(''):
btagInfo.fatJets = fatJets
if groomedFatJets != cms.InputTag(''):
btagInfo.groomedFatJets = groomedFatJets

resulting in a failure of the test runtestPhysicsToolsPatAlgos (see for example this log).
This PR fixes the issue by removing the setupSVClustering calls where unnecessary.

PR validation:

scram b runtests_runtestPhysicsToolsPatAlgos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 7, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c0047/43657/summary.html
COMMIT: 5a33632
CMSSW: CMSSW_15_0_X_2025-01-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47052/43657/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818730
  • DQMHistoTests: Total failures: 542
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3818168
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

urgent

  • fixes IB unit tests

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 8, 2025

+1

@ftorrresd
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants