add fillDescriptions to several more plugins in the reco area used at HLT (2/N)

[mmusich]

PR description:

This PR is similar in spirit to #47017. It adds fillDescriptions (and applies light modification to modernize the source code) to a bunch of plugins in the Reco area used at HLT

PR validation:

• addOnTests.py runs fine.
• hltPhase2UpgradeIntegrationTests runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47045/43174

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CommonTools/RecoAlgos (reconstruction)
• JetMETCorrections/Modules (reconstruction)
• RecoBTag/Combined (reconstruction)
• RecoBTag/SecondaryVertex (reconstruction)
• RecoJets/JetAssociationProducers (reconstruction)
• RecoJets/JetProducers (reconstruction)
• RecoMuon/L2MuonProducer (hlt, reconstruction)
• RecoMuon/MuonIdentification (reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)
• RecoVertex/AdaptiveVertexFinder (reconstruction)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Ming-Yan, @Senphy, @VinInn, @VourMa, @abbiendi, @ahinzmann, @andrea21z, @andrzejnovak, @bellan, @castaned, @cericeci, @clelange, @dgulhan, @fabiocos, @gkasieczka, @gouskos, @hatakeyamak, @jdamgov, @jdolen, @jhgoh, @mariadalfonso, @martinamalberti, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @rappoccio, @rociovilar, @rovere, @schoef, @seemasharmafnal, @silviodonato, @trocino, @yslai this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: HeaderConsistency
Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cac50a/43628/summary.html
COMMIT: f50a874
CMSSW: CMSSW_15_0_X_2025-01-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47045/43628/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 154 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3931808
• DQMHistoTests: Total failures: 3552
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3928236
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #47045 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 88KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cac50a/43634/summary.html
COMMIT: f046bd8
CMSSW: CMSSW_15_0_X_2025-01-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47045/43634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 155 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3931808
• DQMHistoTests: Total failures: 3591
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3928197
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[Dr15Jones]

I think this broke the unit test runtestPhysicsToolsPatAlgos

[mmusich]

I think this broke the unit test runtestPhysicsToolsPatAlgos

it is already fixed by #47052