add fillDescriptions to a bunch of plugins in the EventFilter and Reco areas used at HLT (1/N)

[mmusich]

PR description:

TSG has started to investigate possible replacements of the current Configuration DB model for storing HLT menus in view of the Phase 2 upgrade.
One of the possibilities that was discussed is to fetch the list of configurable parameters uniquely from the auto-generated configuration fragment files that the fillDescriptions mechanism provides in cmssw.
At the moment, this is unfortunately not possible as not all the plugins used at HLT have a viable fillDescriptions implementation.
The goal of this PR is start a campaign of additions in order that this is the case for all the edm modules used at HLT both in Run 3 and Phase 2 menus. Thanks to the additional configuration validation few invalid parameters were identified and were removed from HLT and offline reconstruction configurations.

PR validation:

This branch passes:

• addOnTests.py
• hltPhase2UpgradeIntegrationTests
• runTheMatrix.py -l limited --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will not be backported

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47017/43125

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction  #45853
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Remove the configuration of the legacy CUDA workflows #46076, Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• EventFilter/DTRawToDigi (reconstruction)
• EventFilter/RawDataCollector (daq)
• HLTrigger/Configuration (hlt)
• RecoLocalMuon/CSCSegment (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoLocalTracker/SiStripClusterizer (reconstruction)
• RecoLocalTracker/SubCollectionProducers (reconstruction)
• RecoMET/METProducers (reconstruction)
• RecoMuon/MuonSeedGenerator (reconstruction)
• RecoMuon/TrackingTools (reconstruction)
• RecoParticleFlow/PFTracking (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• RecoVertex/PixelVertexFinding (reconstruction)

@Martin-Grunewald, @cmsbuild, @emeschi, @jfernan2, @mandrenguyen, @mmusich, @smorovic can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VinInn, @VourMa, @abbiendi, @ahinzmann, @alesaggio, @andrea21z, @argiro, @battibass, @bellan, @cericeci, @dgulhan, @dkotlins, @echabert, @fabiocos, @felicepantaleo, @ferencek, @gbenelli, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @jhgoh, @jlidrych, @lgray, @mariadalfonso, @martinamalberti, @missirol, @mmarionncern, @mmusich, @mroguljic, @mtosi, @nhanvtran, @ptcox, @rchatter, @robervalwalsh, @rociovilar, @rovere, @schoef, @seemasharmafnal, @silviodonato, @thomreis, @threus, @trocino, @tsusa, @tvami, @wang0jin, @yduhm this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

Since now there will be fillDescriptions generated cfi files, any old hand-made cfi files in ../python should then be removed or include the generated cfi files (as they are out of sync or may go out of sync), some examples:
https://github.com/cms-sw/cmssw/blob/master/RecoTracker/MeasurementDet/python/MaskedMeasurementTrackerEventProducer_cfi.py
https://github.com/cms-sw/cmssw/blob/master/RecoMET/METProducers/python/HcalHaloData_cfi.py
https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47017/43130

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction  #45853
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Remove the configuration of the legacy CUDA workflows #46076, Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853

[cmsbuild]

Pull request #47017 was updated. @Martin-Grunewald, @cmsbuild, @emeschi, @jfernan2, @mandrenguyen, @mmusich, @smorovic can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-505930/43614/summary.html
COMMIT: 587ebde
CMSSW: CMSSW_15_0_X_2025-01-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47017/43614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 389 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3931808
• DQMHistoTests: Total failures: 7681
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3924107
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[smorovic]

+daq

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

Looks like this PR broke several unit tests of the package Configuration/DataProcessing, see e.g. this log.
I fixed it at #47054.