fix a bunch of tests broken by cms-sw/cmssw#46582

[mmusich]

PR description:

Title says it all, addresses #46582 (comment)

PR validation:

scram b runtests runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A - not needed.

[cmsbuild]

cms-bot internal usage

[mmusich]

test parameters:

• enable = hlt_p2_integration, hlt_p2_timing

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46608/42505

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CalibTracker/StandaloneTrackerTopology (alca)
• Geometry/MTDCommonData (upgrade, geometry)
• Geometry/MTDGeometryBuilder (upgrade, geometry)
• Geometry/MTDNumberingBuilder (upgrade, geometry)
• HLTrigger/Configuration (hlt)
• RecoTracker/TkNavigation (reconstruction)
• Validation/Geometry (dqm, geometry)

@Dr15Jones, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @perrotta, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @SohamBhattacharya, @VinInn, @VourMa, @apsallid, @bsunanda, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @martinamalberti, @missirol, @mmusich, @mtosi, @rbartek, @rishabhCMS, @rovere, @rsreds, @silviodonato, @tocheng, @vargasa, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

Thx @mmusich
It seems this does not cover all remainings, but one needed for IB test. We can go ahead with this, and I will do the rest after this PR is merged.

[srimanob]

@cmsbuild please test

[mmusich]

It seems this does not cover all remainings, but one needed for IB test

not sure, to understand, what's missing?

[srimanob]

If we look on
https://github.com/search?q=repo%3Acms-sw%2Fcmssw+GeometryExtended2026D&type=code&p=1
we will see some missings, i.e. in
SimGeneral/Debugging/python/caloParticleDebugger_cfg.py
L1Trigger/TrackerDTC/test/testDAQ_cfg.py
which my first scan missed.

I also want to update the filenames and related calls, e.g.

CondTools/Geometry/test/calogeometry2026writer.py
CondTools/Geometry/test/geometry2026test_local.py
CondTools/Geometry/test/writehelpers/geometryExtended2026_writer.py
CondTools/Geometry/test/writehelpers/geometryExtended2026_xmlwriter.py

They do not need to get green lights in ib. If you would like to include in your PR, you can go ahead. Or I will do it later.

[mmusich]

we will see some missings

OK, but these are untested, which means we can assume them by default broken.

[srimanob]

we will see some missings

OK, but these are untested, which means we can assume them by default broken.

Right. One which include already, or missing, some of them are broken by default (link to non-existing geometry, ... etc). But I think I will update them all, and also clean up.

[fabiocos]

@srimanob why forcing a default here, since the choice of the version is left free elsewhere? I mean unit tests like those in RecoMTD/DetLayers or SimG4CMS/Forward. This can be practical for standard unit test behaviour, less for development use of the cfgs... Of course it can be bypassed by overwriting the default, but the logic does not seem uniform everywhere.

[mmusich]

urgent

• to fix broken unit tests in IBs

[smuzaffar]

@smuzaffar it looks like test hlt-p2-integration has problem starting. I noticed the same earlier in #46539. Do you have any idea if / where there is a problem?

hlt-p2-integration is running now

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e7ae7/42611/summary.html
COMMIT: 3412226
CMSSW: CMSSW_14_2_X_2024-11-05-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46608/42611/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• You potentially removed 184 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3449886
• DQMHistoTests: Total failures: 533
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449333
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 199 log files, 177 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[Moanwar]

+Upgrade

[civanch]

+1

my impression is that there is no overlaps with @bsunanda PRs.

[mmusich]

@cms-sw/dqm-l2 @cms-sw/reconstruction-l2 please sign, so that we can clean the 23:00 IB.

[srimanob]

Do we understand why we see failure comparisons across all Phase-2?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-05-2300+5e7ae7/65473/validateJR.html

[mmusich]

Do we understand why we see failure comparisons across all Phase-2?

yes. #46416

[jfernan2]

+1

[antoniovagnerini]

+1

• spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@cms-sw/orp-l2 kind ping to merge this (it restores some functionality broken earlier, and other PRs depend on the availability of these tests).