Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: update unit tests for default Phase2 scenario definition #46621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Nov 7, 2024

PR description:

Following the recent renaming of Phase2 geometry configurations, and the introduction of a default Phase2 scenario definition, this PR continue the migration of MTD-related unit tests in #46608 , by porting tests in SimG4CMS/Forward (ideal geometry in G4 model building) and RecMTD/DetLayers (navigation of tracking geometry needed by reconstruction).
The latter is also moved to use the DD4hep backend.

PR validation:

scram b runtests runs successfully.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • RecoMTD/DetLayers (upgrade, reconstruction)
  • SimG4CMS/Forward (simulation)

@Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti, @missirol, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

…to use the new default Phase2 scenario management
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

Pull request #46621 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-659a10/42649/summary.html
COMMIT: 5559a63
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46621/42649/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.0000012024.000001_RunZeroBias2024B_10k/step1_dasquery.log
  • 2024.1010012024.101001_RunBTagMu2024C_10k/step1_dasquery.log
  • 2024.2020012024.202001_RunJetMET02024D_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2024.303001
  • 2024.000001
  • 2024.101001
  • 2024.202001
  • 2024.303001

RelVals-INPUT

  • 2022.0020012022.002001_RunZeroBias2022C_10k/step1_dasquery.log
  • 2023.0000012023.000001_RunMuonEG2023D_10k/step1_dasquery.log
  • 2023.0010012023.001001_RunDisplacedJet2023D_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2023.002001
  • 2022.002001
  • 2023.000001
  • 2023.001001
  • 2023.002001

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 7, 2024

errors are clearly unrelated to this PR, the unit tests are ok

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 7, 2024

+1

@civanch
Copy link
Contributor

civanch commented Nov 7, 2024

+1

@Moanwar
Copy link
Contributor

Moanwar commented Nov 7, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants