-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: update unit tests for default Phase2 scenario definition #46621
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46621/42524 |
A new Pull Request was created by @fabiocos for master. It involves the following packages:
@Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…to use the new default Phase2 scenario management
93c0bac
to
5559a63
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46621/42526 |
Pull request #46621 was updated. @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again. |
please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
Expand to see more relval errors ...
RelVals-INPUT
Expand to see more relval errors ...
|
errors are clearly unrelated to this PR, the unit tests are ok |
+1 |
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
Following the recent renaming of Phase2 geometry configurations, and the introduction of a default Phase2 scenario definition, this PR continue the migration of MTD-related unit tests in #46608 , by porting tests in
SimG4CMS/Forward
(ideal geometry in G4 model building) andRecMTD/DetLayers
(navigation of tracking geometry needed by reconstruction).The latter is also moved to use the DD4hep backend.
PR validation:
scram b runtests
runs successfully.