Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MessageLogger tests to remove obsolete usages #31865

Merged
merged 3 commits into from
Oct 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FWCore/Integration/test/AssociationMapReadTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.load("FWCore.Framework.test.cmsExceptionsFatal_cff")

Expand Down
2 changes: 1 addition & 1 deletion FWCore/Integration/test/AssociationMapTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.load("FWCore.Framework.test.cmsExceptionsFatal_cff")

Expand Down
2 changes: 1 addition & 1 deletion FWCore/Integration/test/RefTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(2)
Expand Down
2 changes: 1 addition & 1 deletion FWCore/Integration/test/TransRefTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(2)
Expand Down
2 changes: 1 addition & 1 deletion FWCore/Integration/test/ViewTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(3)
Expand Down
2 changes: 1 addition & 1 deletion FWCore/Integration/test/parentlessTest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
process.load("FWCore.MessageLogger.MessageLogger_cfi")
process.MessageLogger.destinations = ['cerr']
process.MessageLogger.statistics = []
process.MessageLogger.fwkJobReports = []


process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(2)
Expand Down
8 changes: 1 addition & 7 deletions FWCore/MessageService/bin/Standalone.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,12 @@ int main(int, char* argv[]) {
"untracked PSet infos = {"
"untracked string threshold = 'INFO'"
"untracked PSet default = {untracked int32 limit = 1000000}"
"untracked PSet FwkJob = {untracked int32 limit = 0}"
"}"
"untracked PSet warnings = {"
"untracked string threshold = 'WARNING'"
"untracked PSet default = {untracked int32 limit = 1000000}"
"}"
"untracked vstring fwkJobReports = {'FrameworkJobReport.xml'}"
"untracked vstring categories = {'FwkJob'}"
"untracked PSet FrameworkJobReport.xml = {"
"untracked PSet default = {untracked int32 limit = 0}"
"untracked PSet FwkJob = {untracked int32 limit = 10000000}"
"}"
"untracked vstring categories = {}"
"}"
"service = JobReportService{}"
"service = SiteLocalConfigService{}"
Expand Down
4 changes: 2 additions & 2 deletions FWCore/MessageService/test/AAA_AtlasOfTests
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Tests marked $ are tested in both single thread and multithread running.
Tests marked % are tested with both the default and EDM_ML_DEBUG defined.

u1 $% Gives different thresholds to multiple destinations, and assigns
limit=0 to annoying message categories preEventProcessing and FwkJob.
limit=0 to annoying message categories preEventProcessing and FwkTest.
Incidnetally tests noTimeStamps. Also generates a job report file
(u1_job_report.mxml).
---------- UnitTestClient_A
Expand Down Expand Up @@ -32,7 +32,7 @@ u5 $ Tests reset versus no reset behavior when multiple statistics
u6 $ Tests hex and other manipulators
---------- UnitTestClient_C

u7 Filtering all but one category (for example FwkJob).
u7 Filtering all but one category (for example FwkTest).
Creates a fwkJobReports u7_job_report.mxml as well as logs.
---------- UnitTestClient_C

Expand Down
2 changes: 1 addition & 1 deletion FWCore/MessageService/test/MLexampleModule_1.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace edmtest {
edm::LogWarning("cat_B") << "LogWarning was used to send this other message";
edm::LogInfo("cat_A") << "LogInfo was used to send this message";
edm::LogInfo("cat_B") << "LogInfo was used to send this other message";
edm::LogInfo("FwkJob") << "<Message>LogInfo was used to send a job report</Message>";
edm::LogInfo("FwkTest") << "<Message>LogInfo was used to send a job report</Message>";

} // MessageLoggerClient::analyze()

Expand Down
11 changes: 5 additions & 6 deletions FWCore/MessageService/test/PsetValidationSamples/cat_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
destinations = cms.untracked.vstring( 'u1_warnings', 'u1_errors',
'u1_infos', 'u1_debugs', 'u1_default', 'u1_x'),
statistics = cms.untracked.vstring( 'u1_warnings', 'u1_default', 'u1_y' ),
fwkJobReports = cms.untracked.vstring( 'u1_f' ),
categories = cms.untracked.vstring('preEventProcessing','FwkJob',
categories = cms.untracked.vstring('preEventProcessing','FwkTest',
'cat_A','cat_B', 'cat_J', 'cat_K'),

# enabling any of these acter the first one should fail:
Expand All @@ -39,7 +38,7 @@
u1_x = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down Expand Up @@ -67,7 +66,7 @@
u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -81,7 +80,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -90,7 +89,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down
19 changes: 9 additions & 10 deletions FWCore/MessageService/test/PsetValidationSamples/categories_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,17 @@
destinations = cms.untracked.vstring( 'u1_warnings', 'u1_errors',
'u1_infos', 'u1_debugs', 'u1_default', 'u1_x'),
statistics = cms.untracked.vstring( 'u1_warnings', 'u1_default', 'u1_y'),
fwkJobReports = cms.untracked.vstring( 'u1_f' ),

#enable one of the following -- the first should pass, the rest fail
categories = cms.untracked.vstring('preEventProcessing','FwkJob',
categories = cms.untracked.vstring('preEventProcessing','FwkTest',
'cat_A','cat_B'),
# categories = cms.vstring('preEventProcessing','FwkJob','u1_x'),
# categories = cms.vstring('preEventProcessing','FwkJob','u1_y'),
# categories = cms.vstring('preEventProcessing','FwkJob','u1_f'),
# categories = cms.vstring('preEventProcessing','FwkTest','u1_x'),
# categories = cms.vstring('preEventProcessing','FwkTest','u1_y'),
# categories = cms.vstring('preEventProcessing','FwkTest','u1_f'),
# categories = cms.untracked.int32(2),
# categories = cms.untracked.vstring('preEventProcessing','FwkJob',
# categories = cms.untracked.vstring('preEventProcessing','FwkTest',
# 'cat_A','cat_B','cat_A'),
# categories = cms.untracked.vstring('preEventProcessing','FwkJob',
# categories = cms.untracked.vstring('preEventProcessing','FwkTest',
# 'cat_A','cat_B','limit'),

# If the passing one above enabled, enabling this should now fail:
Expand All @@ -35,7 +34,7 @@
u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -49,7 +48,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -58,7 +57,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
destinations = cms.untracked.vstring( 'u1_warnings', 'u1_errors',
'u1_infos', 'u1_debugs', 'u1_default', 'u1_x'),
statistics = cms.untracked.vstring( 'u1_warnings', 'u1_default', 'u1_y'),
fwkJobReports = cms.untracked.vstring( 'u1_f' ),
categories = cms.untracked.vstring('preEventProcessing','FwkJob',
categories = cms.untracked.vstring('preEventProcessing','FwkTest',
'cat_A','cat_B'),

#enable one of the following -- the first THREE should pass, the rest fail
Expand All @@ -34,7 +33,7 @@
u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -48,7 +47,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -57,7 +56,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down
11 changes: 5 additions & 6 deletions FWCore/MessageService/test/PsetValidationSamples/dest_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,15 @@
destinations = cms.untracked.vstring( 'u1_warnings', 'u1_errors',
'u1_infos', 'u1_debugs', 'u1_default', 'u1_x'),
statistics = cms.untracked.vstring( 'u1_warnings', 'u1_default', 'u1_y' ),
fwkJobReports = cms.untracked.vstring( 'u1_f' ),
categories = cms.untracked.vstring('preEventProcessing','FwkJob',
categories = cms.untracked.vstring('preEventProcessing','FwkTest',
'cat_A','cat_B'),

# enabling any of these except the first 5 should fail:

u1_x = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down Expand Up @@ -53,7 +52,7 @@
u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -67,7 +66,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -76,7 +75,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -51,7 +51,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -60,7 +60,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -71,10 +71,9 @@
threshold = cms.untracked.string('ERROR'),
noTimeStamps = cms.untracked.bool(True)
),
fwkJobReports = cms.untracked.vstring('u1_job_report.mxml'),
debugModules = cms.untracked.vstring('*'),
categories = cms.untracked.vstring('preEventProcessing',
'FwkJob')
'FwkTest')
)

process.maxEvents = cms.untracked.PSet(
Expand Down
18 changes: 4 additions & 14 deletions FWCore/MessageService/test/PsetValidationSamples/fwkJRlist_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,11 @@
'u1_infos', 'u1_debugs', 'u1_default', 'u1_x'),
statistics = cms.untracked.vstring( 'u1_warnings', 'u1_default', 'u1_y'),

#enable one of the following -- the first should pass, the rest fail
# fwkJobReports = cms.untracked.vstring( 'u1_f' ),
# fwkJobReports = cms.vstring('cout'),
# fwkJobReports = cms.untracked.int32(2),
# fwkJobReports = cms.untracked.vstring('u1_warnings', 'u1_errors', 'u1_warnings'),
# fwkJobReports = cms.untracked.vstring('cout','limit'),
# fwkJobReports = cms.untracked.vstring('u1_y'),
# fwkJobReports = cms.untracked.vstring('u1_x'),
fwkJobReports = cms.untracked.vstring('u1_y','u1_x'),


u1_infos = cms.untracked.PSet(
threshold = cms.untracked.string('INFO'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -44,7 +34,7 @@
u1_debugs = cms.untracked.PSet(
threshold = cms.untracked.string('DEBUG'),
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -53,7 +43,7 @@
),
u1_default = cms.untracked.PSet(
noTimeStamps = cms.untracked.bool(True),
FwkJob = cms.untracked.PSet(
FwkTest = cms.untracked.PSet(
limit = cms.untracked.int32(0)
),
preEventProcessing = cms.untracked.PSet(
Expand All @@ -66,7 +56,7 @@
),
debugModules = cms.untracked.vstring('*'),
categories = cms.untracked.vstring('preEventProcessing',
'FwkJob')
'FwkTest')
)

process.maxEvents = cms.untracked.PSet(
Expand Down
Loading