Updated MessageLogger tests to remove obsolete usages #31865

Dr15Jones · 2020-10-19T20:41:36Z

PR description:

removed the use of fwkJobReports parameter as that parameter has done nothing for years.
change FwkJob to FwkTest to better reflect how it has been used for years.

NOTE: neither were removed from the _cfi files used outside of the tests as that could break existing configurations. Such a change will be done at a later date.

PR validation:

Relevant framework unit tests pass.

cmsbuild · 2020-10-19T20:42:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-19T20:48:40Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31865/19225

This PR adds an extra 216KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/MessageService/bin/Standalone.cpp modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
- File FWCore/MessageService/test/u14_cfg.py modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/u21_cfg.py modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/unit_test_outputs/u3_statistics.log modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/unit_test_outputs/u4_another.log modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31865/19225/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31865/19225/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-19T20:53:46Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-19T21:00:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31865/19226

This PR adds an extra 96KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/MessageService/bin/Standalone.cpp modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
- File FWCore/MessageService/test/u14_cfg.py modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/u21_cfg.py modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/unit_test_outputs/u3_statistics.log modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815
- File FWCore/MessageService/test/unit_test_outputs/u4_another.log modified in PR(s): Added LogFwk* logging levels to be used by the framework #31815

cmsbuild · 2020-10-19T21:01:13Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Integration
FWCore/MessageService
FWCore/Services

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-10-19T21:01:29Z

please test

cmsbuild · 2020-10-19T21:01:35Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10107/console Started: 2020/10/19 23:04

cmsbuild · 2020-10-19T22:17:26Z

+1
Tested at: bdce5a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10107/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-19T22:17:30Z

Comparison job queued.

cmsbuild · 2020-10-20T00:25:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10107/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543752
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543723
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-10-20T01:25:26Z

@Dr15Jones There are merge conflicts (caused by the merge of #31815)

cmsbuild · 2020-10-20T13:43:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-20T13:52:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31865/19249

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/MessageService/bin/Standalone.cpp modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629

cmsbuild · 2020-10-20T13:52:48Z

Pull request #31865 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

Dr15Jones · 2020-10-20T13:53:15Z

please test

cmsbuild · 2020-10-20T13:53:37Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10132/console Started: 2020/10/20 15:54

cmsbuild · 2020-10-20T17:26:46Z

+1
Tested at: 5e602a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10132/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Removed unused fwkJobReports from MessageLogger in Geometry Subsystem #31858 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Geometry Subsystem
Added LogFwk* logging levels to be used by the framework #31815 @Dr15Jones: Added LogFwk* logging levels to be used by the framework
Sub-event aware genJet and parton matching for HI miniAOD #31698 @mandrenguyen: Sub-event aware genJet and parton matching for HI miniAOD
ES DQM: Enable concurrent processing of lumisections #31829 @tanmaymudholkar: ES DQM: Enable concurrent processing of lumisections
Add anti-electron tauID for phase2 #31470 @cms-tau-pog: Add anti-electron tauID for phase2
Add maximum of pileup pT hats in JME custom NanoAOD #31831 @nurfikri89: Add maximum of pileup pT hats in JME custom NanoAOD
Removed unused fwkJobReports from MessageLogger from DQMServices Subsystem #31855 @Dr15Jones: Removed unused fwkJobReports from MessageLogger from DQMServices Subsystem
Removed unused fwkJobReports from MessageLogger in Validation Subsystem #31862 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in Validation Subsystem
Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem #31861 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in SLHCUpgradeSimulations Subsystem
Removed unused fwkJobReports from MessageLogger in IOMC Subsystem #31860 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in IOMC Subsystem
Removed unused fwkJobReports from MessageLogger in GeneratorInterface Subsystem #31857 @Dr15Jones: Removed unused fwkJobReports from MessageLogger in GeneratorInterface Subsystem

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10132/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10132/git-merge-result

cmsbuild · 2020-10-20T17:26:49Z

Comparison job queued.

cmsbuild · 2020-10-20T18:42:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2590b7/10132/summary.html

The workflows 158.01 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2415615
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2415589
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 142 log files, 21 edm output root files, 35 DQM output files

makortel · 2020-10-21T13:22:48Z

+1

The Reco differences are caused by #31470 that was included in the test on top of the IB.

cmsbuild · 2020-10-21T13:23:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-21T14:00:03Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 19, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Oct 19, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 19, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 19, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 19, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2020

cmsbuild added comparison-pending tests-pending labels Oct 20, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 20, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Oct 21, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 21, 2020

cmsbuild merged commit bb15b10 into cms-sw:master Oct 21, 2020

silviodonato mentioned this pull request Oct 22, 2020

Segmentation violation in workflows 33034.0 and 33434.0 (geometry D72) #31895

Closed

Dr15Jones deleted the rmFwkJobReportsFWCore branch October 22, 2020 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated MessageLogger tests to remove obsolete usages #31865

Updated MessageLogger tests to remove obsolete usages #31865

Dr15Jones commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

Dr15Jones commented Oct 19, 2020

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 20, 2020

makortel commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

makortel commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

silviodonato commented Oct 21, 2020

Updated MessageLogger tests to remove obsolete usages #31865

Updated MessageLogger tests to remove obsolete usages #31865

Conversation

Dr15Jones commented Oct 19, 2020

PR description:

PR validation:

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

Dr15Jones commented Oct 19, 2020

cmsbuild commented Oct 19, 2020 • edited Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 20, 2020

makortel commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

Dr15Jones commented Oct 20, 2020

cmsbuild commented Oct 20, 2020 • edited Loading

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

cmsbuild commented Oct 20, 2020

makortel commented Oct 21, 2020

cmsbuild commented Oct 21, 2020

silviodonato commented Oct 21, 2020

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 20, 2020 •

edited

Loading