Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patatrack integration - Pixel vertex reconstruction (11/N) #31723

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 8, 2020

PR description:

Data formats and algorithms for the Pixel vertex reconstruction running on GPU.

PR validation:

Changes in use in the Patatrack releases.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Includes changes from:

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Oct 8, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 8, 2020

For all questions, please address @makortel @felicepantaleo @VinInn @rovere @AdrianoDee @sroychow .
For all changes, please make PRs against cms-patatrack:patatrack_integration_11_N_pixel_vertices .

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 8, 2020

@cmsbuild, please test with #31703 #31721 #31722

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 8, 2020

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

-code-checks

ERROR: Build errors found during clang-tidy run.

CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:5:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 288 warnings (287 in non-user code, 1 with check filters).
--
RecoPixelVertexing/PixelVertexFinding/plugins/PixelVertexSoAFromCUDA.cc:4:10: error: 'CUDADataFormats/Common/interface/HostProduct.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HostProduct.h"
         ^
Suppressed 737 warnings (736 in non-user code, 1 with check filters).
--
CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:5:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 1089 warnings (1088 in non-user code, 1 with check filters).
--
CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:5:10: error: 'CUDADataFormats/Common/interface/HeterogeneousSoA.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Common/interface/HeterogeneousSoA.h"
         ^
Suppressed 1192 warnings (1191 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard added a commit to fwyzard/cms-bot that referenced this pull request Oct 10, 2020
See
[#31703](cms-sw/cmssw#31703) Patatrack integration - common data formats (5/N)
[#31704](cms-sw/cmssw#31704) Patatrack integration - calorimeters shared code (6/N)
[#31719](cms-sw/cmssw#31719) Patatrack integration - ECAL local reconstruction (7/N)
[#31720](cms-sw/cmssw#31720) Patatrack integration - HCAL local reconstruction (8/N)
[#31721](cms-sw/cmssw#31721) Patatrack integration - Pixel local reconstruction (9/N)
[#31722](cms-sw/cmssw#31722) Patatrack integration - Pixel track reconstruction (10/N)
[#31723](cms-sw/cmssw#31723) Patatrack integration - Pixel vertex reconstruction (11/N)
fwyzard added a commit to fwyzard/cms-bot that referenced this pull request Oct 10, 2020
See
  - cms-sw/cmssw#31703: Patatrack integration - common data formats (5/N)
  - cms-sw/cmssw#31704: Patatrack integration - calorimeters shared code (6/N)
  - cms-sw/cmssw#31719: Patatrack integration - ECAL local reconstruction (7/N)
  - cms-sw/cmssw#31720: Patatrack integration - HCAL local reconstruction (8/N)
  - cms-sw/cmssw#31721: Patatrack integration - Pixel local reconstruction (9/N)
  - cms-sw/cmssw#31722: Patatrack integration - Pixel track reconstruction (10/N)
  - cms-sw/cmssw#31723: Patatrack integration - Pixel vertex reconstruction (11/N)
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 19, 2020

I'll fix the conflict when we get close to reviewing and merging this PR...

@cmsbuild
Copy link
Contributor

-code-checks

ERROR: Build errors found during clang-tidy run.

CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:6:10: error: 'CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h"
         ^
Suppressed 322 warnings (321 in non-user code, 1 with check filters).
--
CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:6:10: error: 'CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h"
         ^
Suppressed 760 warnings (759 in non-user code, 1 with check filters).
--
CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:6:10: error: 'CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h"
         ^
Suppressed 1021 warnings (1020 in non-user code, 1 with check filters).
--
CUDADataFormats/Vertex/interface/ZVertexHeterogeneous.h:6:10: error: 'CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h' file not found [clang-diagnostic-error]
#include "CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h"
         ^
Suppressed 1124 warnings (1123 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 6, 2021

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31723/21903

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

Pull request #31723 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @slava77, @jpata, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eea60/14013/summary.html
COMMIT: 0abda2e
CMSSW: CMSSW_11_3_X_2021-04-05-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/31723/14013/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 9338
  • DQMHistoTests: Total failures: 1330
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 8008
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 278.455 KiB( 3 files compared)
  • DQMHistoSizes: changed ( 10824.502 ): 258.217 KiB OfflinePixelPV/pixelVertices
  • DQMHistoSizes: changed ( 10824.502 ): 10.031 KiB OfflinePixelPV/Resolution
  • DQMHistoSizes: changed ( 10824.502 ): 6.666 KiB OfflinePixelPV/Alignment
  • DQMHistoSizes: changed ( 10824.502 ): 3.541 KiB OfflinePixelPV/offlineBeamSpot
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640868
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640845
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Apr 6, 2021

+reconstruction

  • tests run with no unexpected differences
  • some expected differences in pixel vertices are picked up by the GPU monitoring
  • the inline comments have been implemented in a48c872 and 0abda2e

@silviodonato
Copy link
Contributor

merge
the last two commits (a48c872 and 0abda2e) merged after the signature of @cms-sw/dqm-l2 do not affect dqm

@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.