Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix beam*_dqm_sourceclient-live_cfg.py #33378

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 8, 2021

resolves #33356

PR description:

After #31723 was merged, the import in RecoPixelVertexing/Configuration/python/RecoPixelVertexing_cff.py was changed as

- from RecoVertex.PrimaryVertexProducer.OfflinePixel3DPrimaryVertices_cfi import *
+ from RecoPixelVertexing.PixelVertexFinding.PixelVertexes_cff import *

and therefore the configuration of the client changed going from PrimaryVertexProducer to PixelVertexProducer.
This lead to issue #33356.

PR validation:

Run successfully in local:

cd DQM/Integration/python/clients
mkdir upload
voms-proxy-init -voms cms
cmsRun beampixel_dqm_sourceclient-live_cfg.py unitTest=True
cmsRun beam_dqm_sourceclient-live_cfg.py unitTest=True

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport it needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33378/21967

@mmusich mmusich changed the title fix beampixel_dqm_sourceclient-live_cfg.py fix beam*_dqm_sourceclient-live_cfg.py Apr 8, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 8, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33378/21968

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc0dc2/14118/summary.html
COMMIT: ce5b1d2
CMSSW: CMSSW_11_3_X_2021-04-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33378/14118/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865471
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

+1
Thank you @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 9, 2021

+1

@cmsbuild cmsbuild merged commit 8d16e3e into cms-sw:master Apr 9, 2021
@mmusich mmusich deleted the fixIssue33356 branch April 9, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS
4 participants