Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy dqm #31369

Closed
wants to merge 12 commits into from
Closed

Remove legacy dqm #31369

wants to merge 12 commits into from

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Sep 5, 2020 •
edited
Loading

PR description:

This PR replaces #30111 which was created by @schneiml but not merged before his leaving. I started from om schneiml:dqm-remove-blocking-modules and brought back RPC and AlCaBeamMonitor which were fixed in between.

This PR removes (some?) of the remaining modules blocking concurrent lumisections in production jobs.

A random 136 relval with concurrent lumis enabled gave these modules reported:

EcalDQMonitorTask ecalMonitorTask
ESIntegrityTask ecalPreshowerIntegrityTask
L1TStage2CaloLayer1 l1tStage2CaloLayer1

Overall, some of these modules are quite important and we don't want to merge this PR. But it gives an idea of what these modules do and allows to try actually enabling concurrent lumis.

(@silviodonato update:
RPCDcsInfo rpcDcsInfo updated with #31056
ALCARECOTkAlMinBiasDCSFilter -> updated with #30124
)

(@jfernan2 update 20/10/2020
EcalDQMonitorTask ecalMonitorTask fixed by #31689
ESIntegrityTask ecalPreshowerIntegrityTask fixed by #31829
L1TStage2CaloLayer1 l1tStage2CaloLayer1 fixed by #31678
)
PR validation:

None, so far; not supposed to be merged for now.

tanmaymudholkar and others added 12 commits June 11, 2020 06:52
@jfernan2 jfernan2 mentioned this pull request Sep 5, 2020
Closed
@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Sep 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31369/18187

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/Applications
DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorTasks
DQM/EcalPreshowerMonitorModule
DQM/L1TMonitor

@andrius-k, @kmaeshima, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@rchatter, @makortel, @fabiocos, @Martin-Grunewald, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor Author

jfernan2 commented Sep 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

+1
Tested at: aee0c2b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42807a/9150/summary.html
CMSSW: CMSSW_11_2_X_2020-09-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42807a/9150/summary.html

Comparison Summary:

  • You potentially added 6019 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2604448
  • DQMHistoTests: Total failures: 505
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2603921
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -109533.448 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -540.738 KiB EcalBarrel/EBPedestalOnlineTask
  • DQMHistoSizes: changed ( 1000.0,... ): -540.000 KiB EcalBarrel/EBTimingTask
  • DQMHistoSizes: changed ( 1000.0,... ): -290.679 KiB EcalPreshower/ESIntegrityTask
  • DQMHistoSizes: changed ( 1000.0,... ): -285.020 KiB EcalBarrel/EBSummaryClient
  • DQMHistoSizes: changed ( 1000.0,... ): -251.787 KiB EcalEndcap/EESummaryClient
  • DQMHistoSizes: changed ( 1000.0,... ): -243.489 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 1000.0,... ): -243.270 KiB EcalBarrel/EBIntegrityClient
  • DQMHistoSizes: changed ( 1000.0,... ): -229.588 KiB EcalEndcap/EEPedestalOnlineTask
  • DQMHistoSizes: changed ( 1000.0,... ): -229.219 KiB EcalEndcap/EETimingTask
  • DQMHistoSizes: changed ( 1000.0,... ): -162.824 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@silviodonato silviodonato mentioned this pull request Sep 7, 2020
Closed
@cmsbuild cmsbuild mentioned this pull request Sep 18, 2020
Merged
@cmsbuild cmsbuild mentioned this pull request Oct 7, 2020
Merged
@silviodonato silviodonato mentioned this pull request Oct 7, 2020
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 15, 2020
Merged
@jfernan2
Copy link
Contributor Author

please close

@cmsbuild cmsbuild closed this Oct 20, 2020
@silviodonato
Copy link
Contributor

Replaced by #31689,#31678,#31829 (#31699 to test concurrent lumi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-pending operations-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@jfernan2 @cmsbuild @silviodonato @tanmaymudholkar @schneiml