Fix cluster->TP matching for pixel tracking CPU workflow #111

makortel · 2018-08-01T07:26:44Z

This detail got overlooked in #105.

VinInn · 2018-08-01T07:50:53Z

~gpu ????
is it really python syntax?? (of course it is, still...)

makortel · 2018-08-01T07:55:48Z

Yes, ~ is the binary negation. It has been used to negate the results of EDFilters for a long time (see e.g. the example config of #100), and recently I introduced it for the modifiers to be able to handle certain complex cases. (I agree that here it is really an abuse, and the tpCluster config should be organized differently, but I leave that to the post-#100 time).

fwyzard · 2018-08-01T08:25:01Z

Validation/RecoTrack/python/TrackValidation_cff.py

@@ -716,6 +716,7 @@ def _uniqueFirstLayers(layerList):
 tpClusterProducerPixelTrackingOnly = tpClusterProducer.clone()
 # Need to use the modifier to customize because the exact EDProducer type depends on the modifier
 gpu.toModify(tpClusterProducerPixelTrackingOnly, src = "tpClusterProducerHeterogeneousPixelTrackingOnly")
+(~gpu).toModify(tpClusterProducerPixelTrackingOnly, pixelClusterSrc = "siPixelClustersPreSplitting")


mhm, this is above the level of ugliness that I would like to have...

can we set it to siPixelClustersPreSplitting by default, and change it to something else for the gpu case ?

makortel · 2018-08-01T08:38:43Z

Better now? (basically moving the gpu.toReplaceWith() down to TrackValidation_cff).

fwyzard · 2018-08-01T09:03:51Z

I guess... though it took me few minutes to understand the changes.

The reason you couldn't do tpClusterProducerPixelTrackingOnly = tpClusterProducer.clone( pixelClusterSrc = "siPixelClustersPreSplitting" ) in the first place, is that tpClusterProducerPixelTrackingOnly is an EDProducer of a different type depending whether gpu is in effect or not, and the two types use a different parameter (src vs pixelClusterSrc) ?

fwyzard · 2018-08-01T09:06:52Z

So, users of tpClusterProducer should actually use tpClusterProducer in the CPU case, and tpClusterProducerHeterogeneous + tpClusterProducerConverter in the GPU case ?

makortel · 2018-08-01T09:07:54Z

The reason you couldn't do tpClusterProducerPixelTrackingOnly = tpClusterProducer.clone( pixelClusterSrc = "siPixelClustersPreSplitting" ) in the first place, is that tpClusterProducerPixelTrackingOnly is an EDProducer of a different type depending whether gpu is in effect or not, and the two types use a different parameter (src vs pixelClusterSrc) ?

Yes, exactly. This is the nasty side effect of applying toReplaceWith to modules.

(in #100 everybody is forced to clone/modify the CPU/GPU/whatever flavor modules explicitly)

makortel · 2018-08-01T09:09:14Z

So, users of tpClusterProducer should actually use tpClusterProducer in the CPU case, and tpClusterProducerHeterogeneous + tpClusterProducerConverter in the GPU case ?

Yes.

Even though if this model would be fully deployed, there would be only tpClusterProducerHeterogeneous + tpClusterProducerConverter (and the former runs the CPU algorithm in absence of a GPU).

fwyzard · 2018-08-01T10:02:34Z

Validation summary

Reference release CMSSW_10_2_0_pre6 at a674e1f
Development branch CMSSW_10_2_X_Patatrack at d2ca336
Testing PRs:

Fix cluster->TP matching for pixel tracking CPU workflow #111 at 2f9da84

`makeTrackValidationPlots.py` plots

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots for workflow 10824.5
tracking validation plots for workflow 10824.8
tracking validation plots for workflow 10824.7
tracking validation plots for workflow 10824.9

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

tracking validation plots for workflow 10824.5
tracking validation plots for workflow 10824.8
tracking validation plots for workflow 10824.7
tracking validation plots for workflow 10824.9

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference DQM plots for reference release, workflow 10824.5
DQM plots for development release, workflow 10824.5
DQM plots for development release, workflow 10824.8
DQM plots for development release, workflow 10824.7
DQM plots for development release, workflow 10824.9
DQM plots for testing release, workflow 10824.5
DQM plots for testing release, workflow 10824.8
DQM plots for testing release, workflow 10824.7
DQM plots for testing release, workflow 10824.9
DQM comparison for reference workflow 10824.5
DQM comparison for workflow 10824.8
DQM comparison for workflow 10824.7
DQM comparison for workflow 10824.9

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference DQM plots for reference release, workflow 10824.5
DQM plots for development release, workflow 10824.5
DQM plots for development release, workflow 10824.8
DQM plots for development release, workflow 10824.7
DQM plots for development release, workflow 10824.9
DQM plots for testing release, workflow 10824.5
DQM plots for testing release, workflow 10824.8
DQM plots for testing release, workflow 10824.7
DQM plots for testing release, workflow 10824.9
DQM comparison for reference workflow 10824.5
DQM comparison for workflow 10824.8
DQM comparison for workflow 10824.7
DQM comparison for workflow 10824.9

logs and `nvprof`/`nvvp` profiles

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: the python configuration was not created, see the full log for more information
development release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
development release, workflow 10824.8
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
development release, workflow 10824.7
- step3.py: log, visual profile and summary
development release, workflow 10824.9
- step3.py: log, visual profile and summary
testing release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
testing release, workflow 10824.8
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
testing release, workflow 10824.7
- step3.py: log, visual profile and summary
testing release, workflow 10824.9
- step3.py: log, visual profile and summary

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

reference release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: the python configuration was not created, see the full log for more information
development release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
development release, workflow 10824.8
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
development release, workflow 10824.7
- step3.py: log, visual profile and summary
development release, workflow 10824.9
- step3.py: log, visual profile and summary
testing release, workflow 10824.5
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
testing release, workflow 10824.8
- step3.py: log, visual profile and summary
- profile.py: log, visual profile and summary
testing release, workflow 10824.7
- step3.py: log, visual profile and summary
testing release, workflow 10824.9
- step3.py: log, visual profile and summary

Logs

The full log is available at https://fwyzard.web.cern.ch/fwyzard/patatrack/pulls/a5cc8af2966d4af03256e3fb24ad72c24acd3493/log .

fwyzard · 2018-08-01T10:08:10Z

Fixes 10824.5 and 10824.7 .

…low (#111)

Fix cluster->TP matching for pixel tracking CPU workflow

d39a67c

makortel mentioned this pull request Aug 1, 2018

Cluster2TP assoc on GPU #105

Merged

fwyzard requested changes Aug 1, 2018

View reviewed changes

Less ugly?

2f9da84

fwyzard approved these changes Aug 1, 2018

View reviewed changes

fwyzard merged commit 9090a44 into cms-patatrack:CMSSW_10_2_X_Patatrack Aug 1, 2018

fwyzard mentioned this pull request Aug 1, 2018

Remove all remaining calls to cudaStreamSynchronize() #109

Merged

fwyzard pushed a commit that referenced this pull request Oct 8, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

d661b8b

…low (#111)

fwyzard mentioned this pull request Oct 8, 2020

Patatrack integration - Pixel track reconstruction (10/N) cms-sw/cmssw#31722

Merged

fwyzard pushed a commit that referenced this pull request Oct 20, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

34273e6

…low (#111)

fwyzard pushed a commit that referenced this pull request Oct 20, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

8f987f0

…low (#111)

fwyzard pushed a commit that referenced this pull request Oct 23, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

420dd2c

…low (#111)

fwyzard pushed a commit that referenced this pull request Nov 6, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

19239b6

…low (#111)

fwyzard pushed a commit that referenced this pull request Nov 6, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

39418d7

…low (#111)

fwyzard pushed a commit that referenced this pull request Nov 16, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

bed9714

…low (#111)

fwyzard added a commit that referenced this pull request Nov 27, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

199fd98

…low (#111)

fwyzard added a commit that referenced this pull request Nov 28, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

62f59bb

…low (#111)

fwyzard pushed a commit that referenced this pull request Dec 26, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

436b46e

…low (#111)

fwyzard mentioned this pull request Dec 26, 2020

Patatrack integration - Pixel vertex reconstruction (11/N) cms-sw/cmssw#31723

Merged

fwyzard added a commit that referenced this pull request Dec 26, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

8f359ee

…low (#111)

fwyzard pushed a commit that referenced this pull request Dec 29, 2020

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

2d1d201

…low (#111)

fwyzard pushed a commit that referenced this pull request Jan 15, 2021

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

30c4519

…low (#111)

fwyzard pushed a commit that referenced this pull request Apr 1, 2021

Fix Cluster-to-TrackingParticle matching for pixel tracking CPU workf…

1a43506

…low (#111)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cluster->TP matching for pixel tracking CPU workflow #111

Fix cluster->TP matching for pixel tracking CPU workflow #111

makortel commented Aug 1, 2018

VinInn commented Aug 1, 2018

makortel commented Aug 1, 2018

fwyzard Aug 1, 2018

makortel commented Aug 1, 2018

fwyzard commented Aug 1, 2018 •

edited

Loading

fwyzard commented Aug 1, 2018

makortel commented Aug 1, 2018

makortel commented Aug 1, 2018

fwyzard commented Aug 1, 2018

fwyzard commented Aug 1, 2018

Fix cluster->TP matching for pixel tracking CPU workflow #111

Fix cluster->TP matching for pixel tracking CPU workflow #111

Conversation

makortel commented Aug 1, 2018

VinInn commented Aug 1, 2018

makortel commented Aug 1, 2018

fwyzard Aug 1, 2018

Choose a reason for hiding this comment

makortel commented Aug 1, 2018

fwyzard commented Aug 1, 2018 • edited Loading

fwyzard commented Aug 1, 2018

makortel commented Aug 1, 2018

makortel commented Aug 1, 2018

fwyzard commented Aug 1, 2018

Validation summary

makeTrackValidationPlots.py plots

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

DQM GUI plots

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

logs and nvprof/nvvp profiles

/RelValTTbar_13/CMSSW_10_2_0_pre6-PU25ns_102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

/RelValZMM_13/CMSSW_10_2_0_pre6-102X_upgrade2018_realistic_v7-v1/GEN-SIM-DIGI-RAW

Logs

fwyzard commented Aug 1, 2018

fwyzard commented Aug 1, 2018 •

edited

Loading

`makeTrackValidationPlots.py` plots

logs and `nvprof`/`nvvp` profiles