Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table column reorder #804

Merged
merged 210 commits into from
Apr 27, 2023
Merged

feat: Table column reorder #804

merged 210 commits into from
Apr 27, 2023

Conversation

jperals
Copy link
Member

@jperals jperals commented Mar 2, 2023

Description

This PR adds functionality to allow end users to change the order of table columns via the Collection preferences modal.

Screen.Recording.2023-04-14.at.16.47.54.mov

Summary of changes:

  • Added new property contentDisplayPreference to the Collection preferences API
  • Added new property columnDisplay to the Table API, which deprecates visibleColumns
  • Added testing utils for the new Content display preference component

Relevant documents:

  • API: NhFvA7Xl8IeN, BRGmACwwMj6D
  • Design proposal: Sv7zAFtrsTbD
  • Accessibility: bwLyApuxAlbu

How has this been tested?

  • Unit tests
  • Integration tests
  • Manually tested
  • Reviewed by accessibility
  • Visual regression tests are in progress in a separate package

Notes

In order to prevent prematurely releasing this feature, this PR is set to merge into an intermediate branch feat/table-column-reorder-reviewed, which will be then merged into main when everything else is ready for release.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 96.42% and project coverage change: +0.10 🎉

Comparison is base (6f85b64) 91.49% compared to head (89a2457) 91.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   91.49%   91.60%   +0.10%     
==========================================
  Files         593      606      +13     
  Lines       15352    15695     +343     
  Branches     4974     5057      +83     
==========================================
+ Hits        14047    14377     +330     
- Misses       1220     1233      +13     
  Partials       85       85              
Impacted Files Coverage Δ
...ontent-display/keyboard-sensor/utilities/scroll.ts 86.95% <86.95%> (ø)
...ences/content-display/use-drag-and-drop-reorder.ts 95.77% <95.77%> (ø)
...eferences/content-display/keyboard-sensor/index.ts 96.00% <96.00%> (ø)
...tion-preferences/content-display/sortable-item.tsx 96.00% <96.00%> (ø)
...c/collection-preferences/content-display/index.tsx 100.00% <100.00%> (ø)
...rences/content-display/keyboard-sensor/defaults.ts 100.00% <100.00%> (ø)
...ontent-display/keyboard-sensor/utilities/events.ts 100.00% <100.00%> (ø)
...ent-display/keyboard-sensor/utilities/listeners.ts 100.00% <100.00%> (ø)
...ferences/content-display/use-live-announcements.ts 100.00% <100.00%> (ø)
...rc/collection-preferences/content-display/utils.ts 100.00% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ams1
Copy link

ams1 commented Mar 22, 2023

@jperals: does this ~relates also to #683 ?

@jperals
Copy link
Member Author

jperals commented Mar 22, 2023

@jperals: does this ~relates also to #683 ?

Hi @ams1, yes, the aim of this PR is basically to implement the feature that you were describing in that question (reordering Table columns via drag-and-drop in Collection preferences).

pan-kot
pan-kot previously approved these changes Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants