-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Table column reorder #804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 3, 2023 16:56
f258ef5
to
20da87b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 91.49% 91.60% +0.10%
==========================================
Files 593 606 +13
Lines 15352 15695 +343
Branches 4974 5057 +83
==========================================
+ Hits 14047 14377 +330
- Misses 1220 1233 +13
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 10, 2023 11:08
20da87b
to
06aed1e
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 13, 2023 09:34
a9e03a1
to
4e862b8
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 16, 2023 14:33
0997f19
to
15fafdf
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 17, 2023 16:39
15fafdf
to
078f632
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 23, 2023 11:16
5815d63
to
3b1a0e0
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
March 29, 2023 06:33
c161573
to
50227dd
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
April 24, 2023 12:04
4a22da5
to
ea9f506
Compare
jperals
force-pushed
the
feat/table-column-reorder
branch
from
April 24, 2023 12:05
ea9f506
to
cd063e5
Compare
This reverts commit cc5d5ff.
pan-kot
reviewed
Apr 25, 2023
pan-kot
previously approved these changes
Apr 25, 2023
pan-kot
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to allow end users to change the order of table columns via the Collection preferences modal.
Screen.Recording.2023-04-14.at.16.47.54.mov
Summary of changes:
contentDisplayPreference
to the Collection preferences APIcolumnDisplay
to the Table API, which deprecatesvisibleColumns
Relevant documents:
How has this been tested?
Notes
In order to prevent prematurely releasing this feature, this PR is set to merge into an intermediate branch
feat/table-column-reorder-reviewed
, which will be then merged into main when everything else is ready for release.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.