Do not deprecate visibleColumns

cloudscape-design · Apr 24, 2023 · ea9f506 · ea9f506
1 parent 77bcce6
commit ea9f506
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 24 deletions.
diff --git a/...table/deprecated.visible-content.page.tsx → pages/table/visible-content.page.tsx b/...table/deprecated.visible-content.page.tsx → pages/table/visible-content.page.tsx
diff --git a/src/table/__integ__/preferences-integration.test.ts b/src/table/__integ__/preferences-integration.test.ts
@@ -43,7 +43,28 @@ test(
   })
 );
 test(
-  'changes column visibility',
+  'changes column visibility using the visibleColumn property',
+  useBrowser(async browser => {
+    await browser.url('#/light/table/visible-content');
+    const page = new BasePageObject(browser);
+    await page.waitForVisible(wrapper.findRows().toSelector());
+    await expect(
+      page.getElementsText(wrapper.findColumnHeaders().find(`.${headerCellStyles['header-cell-content']}`).toSelector())
+    ).resolves.toEqual(['ID', 'Type', 'DNS name', 'State']);
+
+    await page.click(preferences.findTriggerButton().toSelector());
+    await page.waitForVisible(preferences.findModal().toSelector());
+    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 2).toSelector());
+    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 3).toSelector());
+    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 4).toSelector());
+    await page.click(preferences.findModal().findConfirmButton().toSelector());
+    await expect(
+      page.getElementsText(wrapper.findColumnHeaders().find(`.${headerCellStyles['header-cell-content']}`).toSelector())
+    ).resolves.toEqual(['ID', 'Image ID', 'State']);
+  })
+);
+test(
+  'changes column visibility using the columnDisplay property',
   useBrowser(async browser => {
     await browser.url('#/light/table/hooks');
     const page = new BasePageObject(browser);
@@ -90,24 +111,3 @@ test(
     ).resolves.toEqual(['ID', 'DNS name', 'Type', 'State']);
   })
 );
-test(
-  'changes visible columns using the deprecated Visible Column preference',
-  useBrowser(async browser => {
-    await browser.url('#/light/table/deprecated.visible-content');
-    const page = new BasePageObject(browser);
-    await page.waitForVisible(wrapper.findRows().toSelector());
-    await expect(
-      page.getElementsText(wrapper.findColumnHeaders().find(`.${headerCellStyles['header-cell-content']}`).toSelector())
-    ).resolves.toEqual(['ID', 'Type', 'DNS name', 'State']);
-
-    await page.click(preferences.findTriggerButton().toSelector());
-    await page.waitForVisible(preferences.findModal().toSelector());
-    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 2).toSelector());
-    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 3).toSelector());
-    await page.click(preferences.findModal().findVisibleContentPreference().findToggleByIndex(1, 4).toSelector());
-    await page.click(preferences.findModal().findConfirmButton().toSelector());
-    await expect(
-      page.getElementsText(wrapper.findColumnHeaders().find(`.${headerCellStyles['header-cell-content']}`).toSelector())
-    ).resolves.toEqual(['ID', 'Image ID', 'State']);
-  })
-);
diff --git a/src/table/interfaces.tsx b/src/table/interfaces.tsx
@@ -206,8 +206,6 @@ export interface TableProps<T = any> extends BaseComponentProps {
    * Use it in conjunction with the visible content preference of the [collection preferences](/components/collection-preferences/) component.
    *
    * The order of ids doesn't influence the order in which columns are displayed - this is dictated by the `columnDefinitions` property.
-   *
-   * @deprecated Use the `columnDisplay` property instead.
    * */
   visibleColumns?: ReadonlyArray<string>;