feat: File input, file token group, and file dropzone components #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 11, 2024 10:49
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 771 776 +5
Lines 21820 21846 +26
Branches 7450 7452 +2
=======================================
+ Hits 21013 21039 +26
Misses 799 799
Partials 8 8 ☔ View full report in Codecov by Sentry. |
pan-kot
reviewed
Nov 12, 2024
| props: { | ||
| showFileLastModified, | ||
| showFileSize, | ||
| showFileThumbnail, |
There was a problem hiding this comment.
Let's also add alignment and limit as props and something like useFilesLoading as metadata.
There was a problem hiding this comment.
What do you mean by useFilesLoading? Is there an example you can share?
| import { applyDisplayName } from '../internal/utils/apply-display-name'; | ||
| import { FileDropzoneProps } from './interfaces'; | ||
| import InternalFileDropzone from './internal'; | ||
| import { useFilesDragging } from './use-files-dragging'; |
There was a problem hiding this comment.
Can we add metrics instrumentation to useFilesDragging (as a follow-up, I'd say)?
added 2 commits
November 12, 2024 10:27
katiegeorge
changed the title
pan-kot
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pulls file input, file token group, and file dropzone out of internal and into the public folder.
It also updates file dropzone colors based on discussions with the visual design team.
This PR is part one of multiple for file upload decomposition, to make the pull requests easier to review.
Note: I decided to combine the external PRs to avoid merge conflicts and easier release.
Full plan:
file-uploadvariant to button groupRelated links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.