Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Makes file token group public #3000

Closed
wants to merge 4 commits into from

Conversation

katiegeorge
Copy link
Member

Description

This pulls file token group out of internal and into the public folder.

This PR is part one of multiple for file upload decomposition, to make the pull requests easier to review.

Full plan:

  • File dropzone (internal)
  • File input (internal)
  • File token group (internal)
  • File dropzone (external)
  • File input (external)
  • File token group (external) - this PR
  • Adding file-upload variant to button group

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@katiegeorge katiegeorge changed the title Kg/file token group public feat: Makes file token group public Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (6539f15) to head (dcabba7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3000    +/-   ##
========================================
  Coverage   96.30%   96.30%            
========================================
  Files         771      772     +1     
  Lines       21820    21825     +5     
  Branches     7450     7051   -399     
========================================
+ Hits        21013    21018     +5     
  Misses        799      799            
  Partials        8        8            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge
Copy link
Member Author

Closed in favor of combined PR: #3001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant