feat: Adds test id to side navigation #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2972 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 768 768
Lines 21750 21754 +4
Branches 7434 7378 -56
=======================================
+ Hits 20935 20939 +4
+ Misses 807 762 -45
- Partials 8 53 +45 ☔ View full report in Codecov by Sentry. |
12 tasks
orangevolon
changed the title
orangevolon
changed the title
orangevolon
force-pushed
the
alamiami/adds-test-id-to-side-navigation
branch
from
73bd00a
to
b0990f5
Compare
orangevolon
commented
Nov 11, 2024
| @@ -22,18 +22,26 @@ it('Side navigation with all possible items', async () => { | |||
| type: 'link', | |||
| text: 'Page 1', | |||
| href: '#/page1', | |||
| // this test id deliberately contains double quotes | |||
| // to test the selector escaping | |||
| testId: '"link-page-1"', | |||
There was a problem hiding this comment.
I'd liked to have a separate test case for this like this PR, but this particular component doesn't have any tests dedicated for test utils and to follow the existing structure I opted for this.
orangevolon
requested review from
pan-kot
and removed request for
Al-Dani and
pan-kot
pan-kot
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
testIdprop to option inside the side navigation component.The change will be reflected in select, multi-select, autosuggest and property filter components.
Related links, issue #, if available:
Collective PR: #2985
Project: Improving test utils API
How has this been tested?
Tests added to cover the change.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.